Skip to content

Commit c899d24

Browse files
author
Keith Lowery
committed
Fixed a bug in omniprobe when rocminfo is a symlink - the was the case in the AMD dev cloud and it broke omniprobe. Also modifying to use the latest kerneldb
1 parent 83fc068 commit c899d24

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

external/kerneldb

omniprobe/omniprobe

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,8 @@ def get_default_cache_location():
222222

223223
def get_rocm_path():
224224
tmp = shutil.which("rocminfo")
225+
if tmp:
226+
tmp = os.path.realpath(tmp)
225227
nodes = tmp.split("/")
226228
if len(nodes) > 2:
227229
return "/".join(nodes[:len(nodes) - 2])

src/test/st.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
echo $PATH
33
#AMDCGN_INSTRUMENTATION_FUNCTIONS_FILE=/work1/amd/klowery/instrument-amdgpu-kernels/dh_comms/build/lib/hip/dh_comms_dev.gfx90a.bc hipcc -fpass-plugin=/work1/amd/klowery/instrument-amdgpu-kernels/build/hip-static/libAMDGCNMemTrace.so -I/opt/rocm/include -I/opt/rocm/include/roctracer -O3 quicktest.cc -L/opt/rocm/roctracer/lib -v -o quicktest
44
#hipcc -L/home1/klowery/.local/lib -ldh_comms -Rpass-analysis=kernel-resource-usage -fpass-plugin=/work1/amd/klowery/logduration/omniprobe/lib/libAMDGCNMemTraceHIP.so -I/home1/klowery/.local/include/dh_comms -fgpu-rdc --offload-arch=gfx90a -std=c++17 -ggdb -O3 quicktest.cc -v -o quicktest
5-
hipcc -fpass-plugin=/work1/amd/klowery/logduration/build/external/instrument-amdgpu-kernels-rocm/build/lib/libAMDGCNSubmitBBStart-rocm.so -fgpu-rdc --offload-arch=gfx90a -std=c++17 -ggdb quicktest.cc -o quicktest
5+
hipcc -fpass-plugin=/work/klowery/omniprobe/build/external/instrument-amdgpu-kernels-rocm/build/lib/libAMDGCNSubmitBBStart-rocm.so -fgpu-rdc --offload-arch=gfx90a -std=c++17 -ggdb quicktest.cc -o quicktest
66
#hipcc -I/opt/rocm/include -I/opt/rocm/include/roctracer -g quicktest.cc -L/opt/rocm/roctracer/lib -v -o quicktest

0 commit comments

Comments
 (0)