[filesystem] add missing tags on configuration structure (#102)

* [filesystem] add missing tags on configuration structure

* comment out gci

* linting

Author: acabarbaye

.golangci.pre-commit.yaml

@@ -9,7 +9,7 @@ linters:
   disable-all: true # Disable defaults, then enable the ones we want
   enable:
     - goimports
-    - gci
+    # - gci FIXME uncomment when https://github.com/golangci/golangci-lint/issues/2985 is fixed
 
 # Auto-fix any found issues
 issues:

.golangci.yaml

@@ -22,7 +22,7 @@ linters:
     - stylecheck
     - gosec
     - goimports
-    - gci
+    # - gci FIXME uncomment when https://github.com/golangci/golangci-lint/issues/2985 is fixed
 
 linters-settings:
   goimports:

changes/202207181519.bugfix

@@ -0,0 +1 @@
+`[filesystem]` Updated limit structure to have tags specified

changes/202207181802.bugfix

@@ -0,0 +1 @@
+`[httptest]` Fixed security issue `(G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec))`

utils/filesystem/limits.go

@@ -27,8 +27,8 @@ func (n *noLimits) Validate() error {
 
 // Limits defines file system limits
 type Limits struct {
-	MaxFileSize  int64
-	MaxTotalSize uint64
+	MaxFileSize  int64  `mapstructure:"max_file_size"`
+	MaxTotalSize uint64 `mapstructure:"max_total_size"`
 }
 
 func (l *Limits) Apply() bool {

utils/http/httptest/testing.go

@@ -10,6 +10,7 @@ import (
 	"net"
 	"net/http"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/require"
 
@@ -20,7 +21,11 @@ import (
 func NewTestServer(t *testing.T, ctx context.Context, handler http.Handler, port string) {
 	list, err := net.Listen("tcp", fmt.Sprintf(":%v", port))
 	require.Nil(t, err)
-	srv := &http.Server{Handler: handler}
+	srv := &http.Server{
+		Handler:           handler,
+		ReadHeaderTimeout: time.Minute,
+		ReadTimeout:       time.Minute,
+	}
 	err = parallelisation.DetermineContextError(ctx)
 	if err != nil {
 		return