Use maxBy instead of minBy

mdedetrich · mdedetrich · commit 134dce5f467f · 2022-01-14T05:49:59.000+01:00
diff --git a/backup-s3/src/main/scala/io/aiven/guardian/kafka/backup/s3/BackupClient.scala b/backup-s3/src/main/scala/io/aiven/guardian/kafka/backup/s3/BackupClient.scala
@@ -64,7 +64,7 @@ class BackupClient[T <: KafkaClientInterface](maybeS3Settings: Option[S3Settings
                       )
                       single
                     case rest =>
-                      val last = rest.minBy(_.initiated)(Ordering[Instant].reverse)
+                      val last = rest.maxBy(_.initiated)(Ordering[Instant])
                       logger.warn(
                         s"Found multiple previously cancelled uploads for key: $key and bucket: ${s3Config.dataBucket}, picking uploadId: ${last.uploadId}"
                       )

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ class BackupClient[T <: KafkaClientInterface](maybeS3Settings: Option[S3Settings`
`64`	`64`	`)`
`65`	`65`	`single`
`66`	`66`	`case rest =>`
`67`		`- val last = rest.minBy(_.initiated)(Ordering[Instant].reverse)`
	`67`	`+ val last = rest.maxBy(_.initiated)(Ordering[Instant])`
`68`	`68`	`logger.warn(`
`69`	`69`	`s"Found multiple previously cancelled uploads for key: $key and bucket: ${s3Config.dataBucket}, picking uploadId: ${last.uploadId}"`
`70`	`70`	`)`