Fixing 403 error always being RateLimiting #685
Merged
+171
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
EricGustin
reviewed
Nov 10, 2025
| return any(header.lower() in [h.lower() for h in headers] for header in RATE_HEADERS) | ||
| # Check if rate limit is actually exhausted (remaining requests is 0) | ||
| headers_lower = {k.lower(): v for k, v in headers.items()} | ||
| remaining = headers_lower.get("x-ratelimit-remaining") |
Member
There was a problem hiding this comment.
x-ratelimit-remaining is probably not universal (?). Quick search for equivalent headers could help us make this more robust ratelimit-remaining, x-rate-limit-remaining, x-app-rate-limit-remaining, etc.
EricGustin
reviewed
Nov 10, 2025
| # Check if rate limit is actually exhausted (remaining requests is 0) | ||
| headers_lower = {k.lower(): v for k, v in headers.items()} | ||
| remaining = headers_lower.get("x-ratelimit-remaining") | ||
| return remaining is not None and remaining.isdigit() and int(remaining) == 0 |
Member
There was a problem hiding this comment.
If the value isn't a digit then are there other common formats that we could handle here?
EricGustin
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reponse 403 was returning RateLimiting all the time, but it was due only checking if rate limiting header exists, but it should be checked if it is 0 also.