Commit 7a164fd
authored
Correct drainPendingOpeners javadoc and document SETTINGS-raise test scope (#2295)
Motivation:
The offerPendingOpener javadoc claims drainPendingOpeners "only
re-offers" a queued opener on a draining connection, which it never
does, and the SETTINGS-raise test does not record what it pins.
Modification:
Reword the javadoc: the opener stays queued because tryAcquireStream
refuses once draining/closed.
Comment raisedLimitDrainsMultiplePendingOpenersInOrder with its scope
and the sibling test for slot accounting.
Result:
Comments only, no behaviour change.1 parent 4f855bb commit 7a164fd
2 files changed
Lines changed: 7 additions & 3 deletions
File tree
- client/src
- main/java/org/asynchttpclient/netty/channel
- test/java/org/asynchttpclient/netty/channel
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | | - | |
128 | | - | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
129 | 130 | | |
130 | 131 | | |
131 | 132 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
330 | 330 | | |
331 | 331 | | |
332 | 332 | | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
333 | 336 | | |
334 | 337 | | |
335 | 338 | | |
| |||
0 commit comments