Skip to content

Turn log(karma) trending experiment on by default #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Turn log(karma) trending experiment on by default #12441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/discovery-provider/integration_tests/challenges/test_trending_challenge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def test_trending_challenge_should_update(app):
rank=1,
id="1",
type="tracks",
version="pnagD",
version="AnlGe",
week="2021-08-20",
)
)
Expand Down
4 changes: 2 additions & 2 deletions packages/discovery-provider/integration_tests/tasks/test_index_trending_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_index_trending_notification(app):
{
"track_id": i,
"score": 100 - i,
"version": TrendingVersion.pnagD.value,
"version": TrendingVersion.AnlGe.value,
"time_range": "week",
"type": TrendingType.TRACKS.name,
}
Expand Down Expand Up @@ -100,7 +100,7 @@ def test_index_trending_notification(app):
{
"track_id": track_id,
"score": 100 - i,
"version": TrendingVersion.pnagD.value,
"version": TrendingVersion.AnlGe.value,
"time_range": "week",
"type": TrendingType.TRACKS.name,
}
Expand Down
4 changes: 2 additions & 2 deletions ...iscovery-provider/integration_tests/tasks/test_index_trending_underground_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_index_trending_underground_notification(app):
{
"track_id": i,
"score": 1000 - i,
"version": TrendingVersion.pnagD.value,
"version": TrendingVersion.AnlGe.value,
"time_range": "week",
"type": TrendingType.TRACKS.name,
}
Expand Down Expand Up @@ -101,7 +101,7 @@ def test_index_trending_underground_notification(app):
{
"track_id": track_id,
"score": 1000 - i,
"version": TrendingVersion.pnagD.value,
"version": TrendingVersion.AnlGe.value,
"time_range": "week",
"type": TrendingType.TRACKS.name,
}
Expand Down
6 changes: 3 additions & 3 deletions packages/discovery-provider/integration_tests/tasks/test_update_trending.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
from src.models.social.aggregate_interval_plays import t_aggregate_interval_plays
from src.models.tracks.track_trending_score import TrackTrendingScore
from src.models.tracks.trending_param import t_trending_params
from src.trending_strategies.pnagD_trending_tracks_strategy import (
TrendingTracksStrategypnagD,
from src.trending_strategies.AnlGe_trending_tracks_strategy import (
TrendingTracksStrategyAnlGe,
)
from src.utils.db_session import get_db

Expand Down Expand Up @@ -341,7 +341,7 @@ def test_update_track_score_query(app):

# setup
setup_trending(db)
updated_strategy = TrendingTracksStrategypnagD()
updated_strategy = TrendingTracksStrategyAnlGe()

with db.scoped_session() as session:
session.execute("REFRESH MATERIALIZED VIEW aggregate_interval_plays")
Expand Down
2 changes: 1 addition & 1 deletion packages/discovery-provider/integration_tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@ def populate_mock_db(db, entities, block_offset=None):
track_id=track_trending_score.get("track_id", i),
type=track_trending_score.get("type", TrendingType.TRACKS.name),
score=track_trending_score.get("score", 0),
version=track_trending_score.get("version", TrendingVersion.pnagD.name),
version=track_trending_score.get("version", TrendingVersion.AnlGe.name),
genre=track_trending_score.get("genre", ""),
time_range=track_trending_score.get("time_range", "week"),
created_at=track_trending_score.get("created_at", datetime.now()),
Expand Down
201 changes: 0 additions & 201 deletions packages/discovery-provider/src/trending_strategies/pnagD_trending_tracks_strategy.py
View file
Open in desktop

This file was deleted.

10 changes: 3 additions & 7 deletions packages/discovery-provider/src/trending_strategies/trending_strategy_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,14 @@
from src.trending_strategies.pnagD_trending_playlists_strategy import (
TrendingPlaylistsStrategypnagD,
)
from src.trending_strategies.pnagD_trending_tracks_strategy import (
TrendingTracksStrategypnagD,
)
from src.trending_strategies.trending_type_and_version import (
TrendingType,
TrendingVersion,
)

DEFAULT_TRENDING_VERSIONS = {
TrendingType.TRACKS: TrendingVersion.pnagD,
TrendingType.UNDERGROUND_TRACKS: TrendingVersion.pnagD,
TrendingType.TRACKS: TrendingVersion.AnlGe,
TrendingType.UNDERGROUND_TRACKS: TrendingVersion.AnlGe,
TrendingType.PLAYLISTS: TrendingVersion.pnagD,
}

Expand All @@ -23,11 +20,10 @@ class TrendingStrategyFactory:
def __init__(self):
self.strategies = {
TrendingType.TRACKS: {
TrendingVersion.pnagD: TrendingTracksStrategypnagD(),
TrendingVersion.AnlGe: TrendingTracksStrategyAnlGe(),
},
TrendingType.UNDERGROUND_TRACKS: {
TrendingVersion.pnagD: TrendingTracksStrategypnagD(),
TrendingVersion.AnlGe: TrendingTracksStrategyAnlGe(),
},
TrendingType.PLAYLISTS: {
TrendingVersion.pnagD: TrendingPlaylistsStrategypnagD(),
Expand Down