Skip to content

Commit bf3294a

Browse files
authored
Merge pull request #53 from AutomateThePlanet/visual-regression-update
Visual regression plugin update
2 parents 5e96d5c + 56a935f commit bf3294a

File tree

21 files changed

+324
-72
lines changed

21 files changed

+324
-72
lines changed

bellatrix.android/src/main/java/solutions/bellatrix/android/infrastructure/junit/AndroidTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
package solutions.bellatrix.android.infrastructure.junit;
1515

1616
import org.junit.jupiter.api.extension.ExtendWith;
17+
import plugins.screenshots.ScreenshotPlugin;
1718
import solutions.bellatrix.android.components.listeners.BddLogging;
1819
import solutions.bellatrix.android.infrastructure.AppLifecyclePlugin;
19-
import solutions.bellatrix.android.infrastructure.DownloadDemoAppsPlugin;
2020
import solutions.bellatrix.android.infrastructure.MobileScreenshotPlugin;
2121
import solutions.bellatrix.android.infrastructure.MobileVideoPlugin;
2222
import solutions.bellatrix.android.services.App;
@@ -33,7 +33,7 @@ public App app() {
3333
@Override
3434
protected void configure() {
3535
addPlugin(AppLifecyclePlugin.class);
36-
addPlugin(MobileScreenshotPlugin.class);
36+
addPluginAs(ScreenshotPlugin.class, MobileScreenshotPlugin.class);
3737
addPlugin(MobileVideoPlugin.class);
3838
//addPlugin(DownloadDemoAppsPlugin.class);
3939
addListener(BddLogging.class);

bellatrix.android/src/main/java/solutions/bellatrix/android/infrastructure/testng/AndroidTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
package solutions.bellatrix.android.infrastructure.testng;
1515

16+
import plugins.screenshots.ScreenshotPlugin;
1617
import solutions.bellatrix.android.components.listeners.BddLogging;
1718
import solutions.bellatrix.android.infrastructure.AppLifecyclePlugin;
1819
import solutions.bellatrix.android.infrastructure.DownloadDemoAppsPlugin;
@@ -30,7 +31,7 @@ public App app() {
3031
@Override
3132
protected void configure() {
3233
addPlugin(AppLifecyclePlugin.class);
33-
addPlugin(MobileScreenshotPlugin.class);
34+
addPluginAs(ScreenshotPlugin.class, MobileScreenshotPlugin.class);
3435
addPlugin(MobileVideoPlugin.class);
3536
addPlugin(DownloadDemoAppsPlugin.class);
3637
addListener(BddLogging.class);

bellatrix.core/src/main/java/solutions/bellatrix/core/plugins/UsesPlugins.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ public <T extends Plugin> void addPlugin(Class<T> plugin, Object... args) {
99
PluginExecutionEngine.addPlugin(SingletonFactory.getInstance(plugin, args));
1010
}
1111

12+
public <T extends Plugin> void addPluginAs(Class key, Class<T> plugin, Object... args) {
13+
var instance = SingletonFactory.getInstance(plugin, args);
14+
SingletonFactory.register(key, instance);
15+
PluginExecutionEngine.addPlugin(instance);
16+
}
17+
1218
public <T extends Listener> void addListener(Class<T> listener, Object... args) {
1319
Objects.requireNonNull(SingletonFactory.getInstance(listener, args)).addListener();
1420
}

bellatrix.desktop/src/main/java/solutions/bellatrix/desktop/infrastructure/junit/DesktopTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
package solutions.bellatrix.desktop.infrastructure.junit;
1515

16+
import plugins.screenshots.ScreenshotPlugin;
1617
import solutions.bellatrix.core.plugins.junit.BaseTest;
1718
import solutions.bellatrix.desktop.components.listeners.BddLogging;
1819
import solutions.bellatrix.desktop.infrastructure.AppLifecyclePlugin;
@@ -30,7 +31,7 @@ public App app() {
3031
@Override
3132
protected void configure() {
3233
addPlugin(AppLifecyclePlugin.class);
33-
addPlugin(DesktopScreenshotPlugin.class);
34+
addPluginAs(ScreenshotPlugin.class, DesktopScreenshotPlugin.class);
3435
addPlugin(DesktopVideoPlugin.class);
3536
addPlugin(DownloadDemoAppsPlugin.class);
3637
addListener(BddLogging.class);

bellatrix.desktop/src/main/java/solutions/bellatrix/desktop/infrastructure/testng/DesktopTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
package solutions.bellatrix.desktop.infrastructure.testng;
1515

16+
import plugins.screenshots.ScreenshotPlugin;
1617
import solutions.bellatrix.core.plugins.testng.BaseTest;
1718
import solutions.bellatrix.desktop.components.listeners.BddLogging;
1819
import solutions.bellatrix.desktop.infrastructure.AppLifecyclePlugin;
@@ -30,7 +31,7 @@ public App app() {
3031
@Override
3132
protected void configure() {
3233
addPlugin(AppLifecyclePlugin.class);
33-
addPlugin(DesktopScreenshotPlugin.class);
34+
addPluginAs(ScreenshotPlugin.class, DesktopScreenshotPlugin.class);
3435
addPlugin(DesktopVideoPlugin.class);
3536
addPlugin(DownloadDemoAppsPlugin.class);
3637
addListener(BddLogging.class);

bellatrix.ios/src/main/java/solutions/bellatrix/ios/infrastructure/junit/IOSTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
package solutions.bellatrix.ios.infrastructure.junit;
1515

16+
import plugins.screenshots.ScreenshotPlugin;
1617
import solutions.bellatrix.core.plugins.junit.BaseTest;
1718
import solutions.bellatrix.ios.components.listeners.BddLogging;
1819
import solutions.bellatrix.ios.infrastructure.AppLifecyclePlugin;
@@ -29,7 +30,7 @@ public App app() {
2930
@Override
3031
protected void configure() {
3132
addPlugin(AppLifecyclePlugin.class);
32-
addPlugin(MobileScreenshotPlugin.class);
33+
addPluginAs(ScreenshotPlugin.class, MobileScreenshotPlugin.class);
3334
addPlugin(MobileVideoPlugin.class);
3435
addPlugin(DownloadDemoAppsPlugin.class);
3536
addListener(BddLogging.class);

bellatrix.ios/src/main/java/solutions/bellatrix/ios/infrastructure/testng/IOSTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
package solutions.bellatrix.ios.infrastructure.testng;
1515

16+
import plugins.screenshots.ScreenshotPlugin;
1617
import solutions.bellatrix.core.plugins.testng.BaseTest;
1718
import solutions.bellatrix.ios.components.listeners.BddLogging;
1819
import solutions.bellatrix.ios.infrastructure.AppLifecyclePlugin;
@@ -29,7 +30,7 @@ public App app() {
2930
@Override
3031
protected void configure() {
3132
addPlugin(AppLifecyclePlugin.class);
32-
addPlugin(MobileScreenshotPlugin.class);
33+
addPluginAs(ScreenshotPlugin.class, MobileScreenshotPlugin.class);
3334
addPlugin(MobileVideoPlugin.class);
3435
addPlugin(DownloadDemoAppsPlugin.class);
3536
addListener(BddLogging.class);

bellatrix.playwright/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<dependency>
2222
<groupId>com.microsoft.playwright</groupId>
2323
<artifactId>playwright</artifactId>
24-
<version>1.44.0</version>
24+
<version>1.49.0</version>
2525
</dependency>
2626
<dependency>
2727
<groupId>org.junit.jupiter</groupId>

bellatrix.playwright/src/main/java/solutions/bellatrix/playwright/infrastructure/junit/WebTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
package solutions.bellatrix.playwright.infrastructure.junit;
1515

1616
import org.junit.jupiter.api.extension.ExtendWith;
17+
import plugins.screenshots.ScreenshotPlugin;
1718
import solutions.bellatrix.core.plugins.junit.BaseTest;
1819
import solutions.bellatrix.core.plugins.junit.TestResultWatcher;
1920
import solutions.bellatrix.core.utilities.SingletonFactory;
@@ -35,7 +36,7 @@ public App app() {
3536
@Override
3637
protected void configure() {
3738
addPlugin(BrowserLifecyclePlugin.class);
38-
addPlugin(WebScreenshotPlugin.class);
39+
addPluginAs(ScreenshotPlugin.class, WebScreenshotPlugin.class);
3940
addPlugin(WebVideoPlugin.class);
4041
addPlugin(LogLifecyclePlugin.class);
4142
addListener(BddConsoleLogging.class);

bellatrix.playwright/src/main/java/solutions/bellatrix/playwright/infrastructure/testng/WebTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
package solutions.bellatrix.playwright.infrastructure.testng;
1515

16+
import plugins.screenshots.ScreenshotPlugin;
1617
import solutions.bellatrix.core.plugins.testng.BaseTest;
1718
import solutions.bellatrix.core.utilities.SingletonFactory;
1819
import solutions.bellatrix.playwright.components.listeners.BddConsoleLogging;
@@ -31,7 +32,7 @@ public App app() {
3132
@Override
3233
protected void configure() {
3334
addPlugin(BrowserLifecyclePlugin.class);
34-
addPlugin(WebScreenshotPlugin.class);
35+
addPluginAs(ScreenshotPlugin.class, WebScreenshotPlugin.class);
3536
addPlugin(WebVideoPlugin.class);
3637
addPlugin(LogLifecyclePlugin.class);
3738
addListener(BddConsoleLogging.class);

0 commit comments

Comments
 (0)