Refactor tests

Author: sjinks

tests/test-object-cache.php

@@ -1073,27 +1073,26 @@ public function test_wp_cache_get_multiple_consistency() {
 		self::assertSame( $values, $actual );
 	}
 
-	public function test_wp_cache_get_consistency() {
-		$values = [
-			'empty-string' => '',
-			'empty-array'  => [],
-			'zero'         => 0,
-			'false'        => false,
-			'null'         => null,
+	/**
+	 * @dataProvider data_wp_cache_get_consistency
+	 */
+	public function test_wp_cache_get_consistency( $value ) {
+		$result = wp_cache_set( 'key', $value, 'group' );
+		self::assertTrue( $result );
+
+		$found  = false;
+		$actual = wp_cache_get( 'key', 'group', true, $found );
+		self::assertTrue( $found );
+		self::assertSame( $value, $actual );
+	}
+
+	public function data_wp_cache_get_consistency() {
+		return [
+			'empty string' => [ '' ],
+			'empty array'  => [ [] ],
+			'zero'         => [ 0 ],
+			'false'        => [ false ],
+			'null'         => [ null ],
 		];
-
-		foreach ( $values as $key => $value ) {
-			$result = wp_cache_set( $key, $value, 'group' );
-			self::assertTrue( $result );
-		}
-
-		$this->object_cache->cache = [];
-
-		foreach ( $values as $key => $expected ) {
-			$found  = false;
-			$actual = wp_cache_get( $key, 'group', true, $found );
-			self::assertTrue( $found );
-			self::assertSame( $expected, $actual );
-		}
 	}
 }