Skip to content

Commit 81d1007

Browse files
authored
Merge pull request #329 from Azure-Samples/jimchou/vite-migration
Migrate chat quickstarts from CRA to Vite
2 parents 0e68b72 + 19b7926 commit 81d1007

File tree

43 files changed

+15926
-70422
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+15926
-70422
lines changed

.github/workflows/ui-library-filesharing-chat-composite.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ jobs:
1919
uses: ./.github/workflows/ci-ui-library.yml
2020
with:
2121
runs-on: 'ubuntu-latest'
22-
node-version: '16.x'
22+
node-version: '22.x'
2323
working-directory: './ui-library-filesharing-chat-composite/app'

.github/workflows/ui-library-filesharing-ui-components.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ jobs:
1919
uses: ./.github/workflows/ci-ui-library.yml
2020
with:
2121
runs-on: 'ubuntu-latest'
22-
node-version: '16.x'
22+
node-version: '22.x'
2323
working-directory: './ui-library-filesharing-ui-components/app'

.github/workflows/ui-library-quickstart-teams-interop-meeting-chat.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ jobs:
1919
uses: ./.github/workflows/ci-ui-library.yml
2020
with:
2121
runs-on: 'ubuntu-latest'
22-
node-version: '16.x'
22+
node-version: '22.x'
2323
working-directory: './ui-library-quickstart-teams-interop-meeting-chat'

.github/workflows/ui-library-starting-with-chat-stateful.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ jobs:
1919
uses: ./.github/workflows/ci-ui-library.yml
2020
with:
2121
runs-on: 'ubuntu-latest'
22-
node-version: '16.x'
22+
node-version: '22.x'
2323
working-directory: './ui-library-starting-with-chat-stateful'

ui-library-add-call-recording/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,3 +95,5 @@ The setup allows you to debug each service separately, but requires some orchest
9595
In either case, navigate to your app at `localhost:4280`.
9696

9797
In this case, the Azure Functions will be served at `localhost:7071`. You will need to expose this port publicly to be able to register it as a webhook with EventGrid.
98+
99+
Currently, `azure-functions-core-tools` supports up to Node.js v20. If you're using a higher version (e.g., v22), you may encounter issues such as `localhost:4280` showing a "This site can’t be reached" error.

ui-library-add-call-recording/app/public/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"short_name": "React App",
3-
"name": "Create React App Sample",
3+
"name": "React App Sample",
44
"icons": [
55
{
66
"src": "favicon.ico",

ui-library-add-call-recording/package-lock.json

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ui-library-add-call-recording/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,8 @@
2424
},
2525
"dependencies": {
2626
"typescript": "^4.5.4"
27+
},
28+
"engines": {
29+
"node": "20.x"
2730
}
2831
}

ui-library-click-to-call/public/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"short_name": "React App",
3-
"name": "Create React App Sample",
3+
"name": "React App Sample",
44
"icons": [
55
{
66
"src": "favicon.ico",

ui-library-filesharing-chat-composite/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ This sample includes:
3838
You need a few Azure resources before running this sample locally.
3939

4040
* An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/?WT.mc_id=A261C142F) .
41-
* [Node.js](https://nodejs.org/en/) Active LTS and Maintenance LTS versions (16.x.x is recommended).
41+
* [Node.js](https://nodejs.org/en/) Active LTS and Maintenance LTS versions (20.x.x is recommended).
4242
* An active Communication Services resource. [Create a Communication Services resource](https://docs.microsoft.com/azure/communication-services/quickstarts/create-communication-resource).
4343
* An identity with Chat scope. Generate an identity using the [Azure Portal](https://docs.microsoft.com/azure/communication-services/quickstarts/identity/quick-create-identity).
4444
* [Azure Storage Account](https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview)
@@ -79,3 +79,5 @@ You'll need to run the client and server separately:
7979

8080

8181
Navigate to your application at `localhost:4280`.
82+
83+
Currently, `azure-functions-core-tools` supports up to Node.js v20. If you're using a higher version (e.g., v22), you may encounter issues such as `localhost:4280` showing a "This site can’t be reached" error.

0 commit comments

Comments
 (0)