From 4b9958cbc55e10cd119d452f2d632530b9b30ad3 Mon Sep 17 00:00:00 2001 From: Chen Jia Date: Thu, 2 Oct 2025 14:57:03 +1000 Subject: [PATCH 1/3] fix: update .gitignore to include tfplan and remove default location in variables.tf --- .gitignore | 3 ++- variables.tf | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 9a7ac54..33fc590 100644 --- a/.gitignore +++ b/.gitignore @@ -39,4 +39,5 @@ override.tf.json terraform.rc # Artifacts -*.zip \ No newline at end of file +*.zip +tfplan diff --git a/variables.tf b/variables.tf index e962ad7..c14431e 100644 --- a/variables.tf +++ b/variables.tf @@ -5,7 +5,6 @@ variable "subscription_id" { variable "location" { description = "The location/region where the resources will be created." - default = "West Europe" type = string } From 24c4ec461bc85c7adc10082bf0ecad8ece319183 Mon Sep 17 00:00:00 2001 From: Chen Jia Date: Thu, 2 Oct 2025 15:01:39 +1000 Subject: [PATCH 2/3] fix: update function app publish resource to use base64sha256 for triggers --- modules/function-app/function-app.tf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/function-app/function-app.tf b/modules/function-app/function-app.tf index aaafc71..c2af508 100644 --- a/modules/function-app/function-app.tf +++ b/modules/function-app/function-app.tf @@ -129,7 +129,8 @@ locals { resource "null_resource" "function_app_publish" { depends_on = [local.publish_code_command, azurerm_role_assignment.role_assignment_storage, azurerm_role_assignment.role_assignment_event_hub] triggers = { - input_json = filemd5(data.archive_file.functions_zip.output_path) + # input_json = filemd5(data.archive_file.functions_zip.output_path) + publish_has = data.archive_file.functions_zip.output_base64sha256 publish_code_command = local.publish_code_command allow_public_access_command = local.allow_public_access_command deny_public_access_command = local.deny_public_access_command From e742df4d4497f1a4276f286d5c9c74b33f41073d Mon Sep 17 00:00:00 2001 From: Chen Jia Date: Tue, 7 Oct 2025 14:11:40 +1100 Subject: [PATCH 3/3] fix: update default Node.js version for function app to 20 --- modules/function-app/function-app.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/function-app/function-app.tf b/modules/function-app/function-app.tf index c2af508..7fe4578 100644 --- a/modules/function-app/function-app.tf +++ b/modules/function-app/function-app.tf @@ -21,7 +21,7 @@ resource "azurerm_windows_function_app" "function_app" { "WEBSITE_RUN_FROM_PACKAGE" = "1", "FUNCTIONS_WORKER_RUNTIME" = "node", "AzureWebJobsDisableHomepage" = "true", - "WEBSITE_NODE_DEFAULT_VERSION" = "~18", + "WEBSITE_NODE_DEFAULT_VERSION" = "~20", "EventHubConnection__credential" = "managedidentity", "EventHubConnection__fullyQualifiedNamespace" = format("%s.servicebus.windows.net", var.event_hub_namespace_name), "DD_API_KEY" = var.datadog_api_key,