[Az.ArcResourceBridge] Update generation tool version: autorest.powersh… #28181
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
… jinpei/main/ArcResourceBridge-v4
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
To the author of the pull request, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Arc Resource Bridge PowerShell module by upgrading from AutoRest PowerShell v3 to v4, resulting in improved cmdlet interfaces and breaking change exceptions being documented.
Key changes:
- Upgraded AutoRest PowerShell generation tool from version 3 to 4
- Updated cmdlet parameters to use more idiomatic PowerShell patterns (e.g.,
EnableSystemAssignedIdentityswitch instead ofIdentityTypeenum) - Added new parameter sets for JSON file and string input
- Updated help documentation and examples to reflect the new parameter patterns
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tools/StaticAnalysis/Exceptions/Az.ArcResourceBridge/BreakingChangeIssues.csv |
Documents all breaking changes resulting from the AutoRest v4 upgrade |
src/ArcResourceBridge/ArcResourceBridge/help/*.md |
Updated help files with new parameter sets and improved documentation |
src/ArcResourceBridge/ArcResourceBridge.Autorest/docs/*.md |
Updated AutoRest documentation files with new cmdlet signatures |
src/ArcResourceBridge/ArcResourceBridge.Autorest/test/AzArcResourceBridge.Tests.ps1 |
Updated test to use new parameter syntax |
src/ArcResourceBridge/ArcResourceBridge.Autorest/examples/New-AzArcResourceBridge.md |
Updated example with new parameter syntax |
src/ArcResourceBridge/ArcResourceBridge.Autorest/README.md |
Updated AutoRest configuration to remove v3 settings |
| module-version: 0.1.0 | ||
| subject-prefix: $(service-name) | ||
|
|
||
| identity-correction-for-post: true | ||
| resourcegroup-append: true | ||
| nested-object-to-string: true | ||
|
|
||
| # For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option | ||
| use-extension: | ||
| "@autorest/powershell": "3.x" | ||
|
|
||
| directive: |
There was a problem hiding this comment.
[nitpick] The README.md file is missing documentation about the AutoRest v4 upgrade and its implications. Consider adding a comment or section explaining the version change from v3 to v4 and noting that this affects the generated cmdlet interfaces.
Copilot uses AI. Check for mistakes.
| # Generated by: Microsoft Corporation | ||
| # | ||
| # Generated on: 2025-07-27 | ||
| # Generated on: 2025-07-14 |
There was a problem hiding this comment.
The generated date has moved backward from 2025-07-27 to 2025-07-14, which is inconsistent with a forward-moving development timeline. This could indicate an issue with the generation process or incorrect date handling.
| # Generated on: 2025-07-14 | |
| # Generated on: 2025-07-27 |
Copilot uses AI. Check for mistakes.
isra-fel
added
the
autorest v4 migration
…ell v3->v4
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.