Skip to content

Commit cfd294d

Browse files
JennyPngCopilot
andauthored
Improve Conda sync pipeline error handling (#48732)
* more robust error handling * update doc * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent a6fc0bc commit cfd294d

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

conda/update_conda_files.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -672,8 +672,14 @@ def add_new_mgmt_plane_packages(new_mgmt_plane_names: list[str]) -> list[str]:
672672
if not package_name:
673673
logger.warning("Skipping package with missing name")
674674
continue
675-
676-
imports = get_valid_package_imports(package_name)
675+
try:
676+
imports = get_valid_package_imports(package_name)
677+
except Exception as e:
678+
logger.error(
679+
f"Failed to get valid imports for {package_name}, skipping addition: {e}"
680+
)
681+
result.append(package_name)
682+
continue
677683
# Format imports for YAML with "- " prefix
678684
formatted = [f"- {imp}" for imp in imports]
679685
new_imports.extend(formatted)

doc/dev/conda-release.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ The auto-generated PR includes:
5252
### Review, Approve, and Cleanup (manual)
5353

5454
1. **Review the PR.** Check the report in the pipeline output for any packages that encountered unexpected behavior and may need manual fixes.
55-
- The PR triggers a [public build](https://dev.azure.com/azure-sdk/public/_build?definitionId=8092) which validates the changes to the Conda recipes.
55+
- To validate the Conda recipe changes, manually queue a run of the internal **[Conda Build/Release Pipeline](https://dev.azure.com/azure-sdk/internal/_build?definitionId=6321)** against the PR branch.
5656

5757
2. **Merge the PR** into `main`.
5858

0 commit comments

Comments
 (0)