fix: compile against BanManager from source and clean up bot on kick

- Checkout BanManager and publishToMavenLocal in both CI workflows so
  WebEnhancer always compiles against the latest API (Fabric Stonecutter
  artifacts are not reliably published to Maven Central snapshots)
- Clean up mineflayer bot (removeAllListeners + end) on kick/error during
  connect() and waitForKick() to prevent physics timers running after
  Jest teardown

Author: confuser

.github/workflows/build.yml

@@ -26,6 +26,12 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      - uses: actions/checkout@v4
+        with:
+          repository: BanManagement/BanManager
+          path: BanManager
+          ref: master
+
       - name: Set up JDK 17
         uses: actions/setup-java@v4
         with:
@@ -47,13 +53,17 @@ jobs:
         with:
           path: |
             .gradle/loom-cache
-          key: ${{ runner.os }}-loom-${{ hashFiles('**/libs.versions.*', '**/*.gradle*', '**/gradle-wrapper.properties') }}-${{ github.run_id }}
+          key: ${{ runner.os }}-loom-${{ hashFiles('**/libs.versions.*', '**/*.gradle*', '**/gradle-wrapper.properties') }}
           restore-keys: ${{ runner.os }}-loom-
 
+      - name: Publish BanManager to Maven Local
+        working-directory: BanManager
+        run: ./gradlew publishToMavenLocal --build-cache
+
       - name: Execute Gradle build
         env:
           STORAGE_TYPE: ${{ matrix.storageType }}
-        run: ./gradlew build --build-cache --refresh-dependencies --info
+        run: ./gradlew build --build-cache --info
 
       - name: Build all Fabric versions
         run: ./gradlew :fabric:1.20.1:remapJar :fabric:1.21.1:remapJar :fabric:1.21.4:remapJar :fabric:1.21.11:remapJar --build-cache

.github/workflows/e2e.yml

@@ -132,9 +132,13 @@ jobs:
         with:
           path: |
             .gradle/loom-cache
-          key: ${{ runner.os }}-loom-${{ hashFiles('**/libs.versions.*', '**/*.gradle*', '**/gradle-wrapper.properties') }}-${{ github.run_id }}
+          key: ${{ runner.os }}-loom-${{ hashFiles('**/libs.versions.*', '**/*.gradle*', '**/gradle-wrapper.properties') }}
           restore-keys: ${{ runner.os }}-loom-
 
+      - name: Publish BanManager to Maven Local
+        working-directory: BanManager
+        run: ./gradlew publishToMavenLocal --build-cache
+
       # Docker Buildx for better caching
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3

e2e/tests/src/helpers/bot.ts

@@ -115,7 +115,16 @@ export class TestBot {
         version: MC_VERSION
       })
 
+      const cleanup = (): void => {
+        if (this.bot != null) {
+          this.bot.removeAllListeners()
+          this.bot.end()
+          this.bot = null
+        }
+      }
+
       const timeout = setTimeout(() => {
+        cleanup()
         reject(new Error('Bot connection timeout'))
       }, 30000)
 
@@ -127,13 +136,15 @@ export class TestBot {
 
       this.bot.once('error', (err) => {
         clearTimeout(timeout)
+        cleanup()
         reject(err)
       })
 
       this.bot.once('kicked', (reason) => {
         clearTimeout(timeout)
         const reasonText = extractKickReason(reason)
         console.log(`Bot ${this._username} was kicked: ${reasonText}`)
+        cleanup()
         reject(new Error(`Bot ${this._username} was kicked: ${reasonText}`))
       })
 
@@ -347,7 +358,8 @@ export class TestBot {
         if (settled) return
         settled = true
         clearTimeout(timeout)
-        bot.removeAllListeners('end')
+        bot.removeAllListeners()
+        bot.end()
         this.bot = null
         resolve(extractKickReason(reason))
       })
@@ -360,7 +372,7 @@ export class TestBot {
           if (settled) return
           settled = true
           clearTimeout(timeout)
-          bot.removeAllListeners('kicked')
+          bot.removeAllListeners()
           this.bot = null
           reject(new Error(`Bot disconnected before kick: ${reason}`))
         }, 500)