Skip to content

Commit 60d40af

Browse files
Updating Enums
1 parent b6ec57b commit 60d40af

File tree

7 files changed

+25
-25
lines changed

7 files changed

+25
-25
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
<plugin>
9090
<groupId>org.apache.maven.plugins</groupId>
9191
<artifactId>maven-surefire-plugin</artifactId>
92-
<version>2.22.2</version>
92+
<version>3.2.5</version>
9393
<configuration>
9494
<systemProperties>
9595
<property>
@@ -409,7 +409,7 @@
409409
<jackson-databind-nullable-version>0.2.3</jackson-databind-nullable-version>
410410
<jakarta-annotation-version>
411411
1.3.5</jakarta-annotation-version>
412-
<junit-version>5.8.2</junit-version>
412+
<junit-version>5.9.1</junit-version>
413413
<junit-platform-runner.version>1.6.2</junit-platform-runner.version>
414414
<mockito-core-version>
415415
3.12.4</mockito-core-version>

src/main/java/com/bandwidth/sdk/model/DiversionReason.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@
1010

1111
@Getter
1212
public enum DiversionReason {
13-
AWAY("away"),
14-
DEFLECTION("deflection"),
15-
DO_NOT_DISTURB("do-not-disturb"),
16-
FOLLOW_ME("follow-me"),
17-
NO_ANSWER("no-answer"),
18-
OUT_OF_SERVICE("out-of-service"),
19-
TIME_OF_DAY("time-of-day"),
20-
UNAVAILABLE("unavailable"),
21-
UNCONDITIONAL("unconditional"),
22-
UNKNOWN("unknown"),
23-
USER_BUSY("user-busy"),
13+
away("away"),
14+
deflection("deflection"),
15+
do_not_disturb("do-not-disturb"),
16+
follow_me("follow-me"),
17+
no_answer("no-answer"),
18+
out_of_service("out-of-service"),
19+
time_of_day("time-of-day"),
20+
unavailable("unavailable"),
21+
unconditional("unconditional"),
22+
unknown("unknown"),
23+
user_busy("user-busy"),
2424
;
2525

2626
private static final Map<String, DiversionReason> DESERIALIZATION_MAP =

src/main/java/com/bandwidth/sdk/model/DiversionTreatment.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
@Getter
1212
public enum DiversionTreatment {
13-
NONE("none"),
14-
PROPAGATE("propagate"),
15-
STACK("stack"),
13+
none("none"),
14+
propagate("propagate"),
15+
stack("stack"),
1616
;
1717

1818
private static final Map<String, DiversionTreatment> DESERIALIZATION_MAP =

src/main/java/com/bandwidth/sdk/model/bxml/Forward.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,11 @@ public class Forward implements Verb {
7373

7474
@XmlAttribute
7575
@Builder.Default
76-
private DiversionTreatment diversionTreatment = DiversionTreatment.NONE;
76+
private DiversionTreatment diversionTreatment = DiversionTreatment.none;
7777

7878
@XmlAttribute
7979
@Builder.Default
80-
private DiversionReason diversionReason = DiversionReason.UNKNOWN;
80+
private DiversionReason diversionReason = DiversionReason.unknown;
8181

8282
@Override
8383
public String getVerbName() {

src/main/java/com/bandwidth/sdk/model/bxml/Transfer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,11 @@ public class Transfer implements Verb {
122122

123123
@XmlAttribute
124124
@Default
125-
protected DiversionTreatment diversionTreatment = DiversionTreatment.NONE;
125+
protected DiversionTreatment diversionTreatment = DiversionTreatment.none;
126126

127127
@XmlAttribute
128128
@Default
129-
protected DiversionReason diversionReason = DiversionReason.UNKNOWN;
129+
protected DiversionReason diversionReason = DiversionReason.unknown;
130130

131131
@Override
132132
public String getVerbName() {

src/test/java/com/bandwidth/sdk/model/unit/bxml/ForwardVerbTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ public class ForwardVerbTest {
2929
.to("+19195554321")
3030
.from("19195554322")
3131
.callTimeout(15d)
32-
.diversionTreatment(DiversionTreatment.PROPAGATE)
33-
.diversionReason(DiversionReason.AWAY)
32+
.diversionTreatment(DiversionTreatment.propagate)
33+
.diversionReason(DiversionReason.away)
3434
.uui("93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt")
3535
.build();
3636

3737
@Test
3838
public void forwardVerbWorks() throws JAXBException {
3939
JAXBContext jaxbContext = JAXBContext.newInstance(Bxml.class);
40-
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><Forward to=\"+19195554321\" from=\"19195554322\" uui=\"93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt\" callTimeout=\"15.0\" diversionTreatment=\"PROPAGATE\" diversionReason=\"AWAY\"/></Bxml>";
40+
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><Forward to=\"+19195554321\" from=\"19195554322\" uui=\"93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt\" callTimeout=\"15.0\" diversionTreatment=\"propagate\" diversionReason=\"away\"/></Bxml>";
4141

4242
assertThat(new Bxml().with(forward).toBxml(jaxbContext), is(expectedBxml));
4343
}

src/test/java/com/bandwidth/sdk/model/unit/bxml/TransferVerbTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ public class TransferVerbTest {
5757
@Test
5858
public void transferVerbWorks() throws JAXBException {
5959
JAXBContext jaxbContext = JAXBContext.newInstance(Bxml.class);
60-
String expectedSipUriBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><Transfer transferCallerId=\"+19195554321\" callTimeout=\"15.0\" transferCompleteMethod=\"POST\" transferCompleteFallbackMethod=\"POST\" tag=\"test\" diversionTreatment=\"NONE\" diversionReason=\"UNKNOWN\"><SipUri uui=\"test\" transferAnswerUrl=\"https://example.com/webhooks/transfer_answer\" transferAnswerMethod=\"POST\" transferAnswerFallbackMethod=\"POST\" transferDisconnectMethod=\"POST\" tag=\"test\">[email protected]</SipUri></Transfer></Bxml>";
61-
String expectedPhoneNumberBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><Transfer transferCallerId=\"+19195554321\" transferCallerDisplayName=\"Clark Kent\" callTimeout=\"15.0\" transferCompleteMethod=\"POST\" transferCompleteFallbackMethod=\"POST\" tag=\"test\" diversionTreatment=\"NONE\" diversionReason=\"UNKNOWN\"><PhoneNumber transferAnswerUrl=\"https://example.com/webhooks/transfer_answer\" transferAnswerMethod=\"POST\" transferAnswerFallbackMethod=\"POST\" transferDisconnectMethod=\"POST\" tag=\"test\">+19195551234</PhoneNumber></Transfer></Bxml>";
60+
String expectedSipUriBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><Transfer transferCallerId=\"+19195554321\" callTimeout=\"15.0\" transferCompleteMethod=\"POST\" transferCompleteFallbackMethod=\"POST\" tag=\"test\" diversionTreatment=\"none\" diversionReason=\"unknown\"><SipUri uui=\"test\" transferAnswerUrl=\"https://example.com/webhooks/transfer_answer\" transferAnswerMethod=\"POST\" transferAnswerFallbackMethod=\"POST\" transferDisconnectMethod=\"POST\" tag=\"test\">[email protected]</SipUri></Transfer></Bxml>";
61+
String expectedPhoneNumberBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><Transfer transferCallerId=\"+19195554321\" transferCallerDisplayName=\"Clark Kent\" callTimeout=\"15.0\" transferCompleteMethod=\"POST\" transferCompleteFallbackMethod=\"POST\" tag=\"test\" diversionTreatment=\"none\" diversionReason=\"unknown\"><PhoneNumber transferAnswerUrl=\"https://example.com/webhooks/transfer_answer\" transferAnswerMethod=\"POST\" transferAnswerFallbackMethod=\"POST\" transferDisconnectMethod=\"POST\" tag=\"test\">+19195551234</PhoneNumber></Transfer></Bxml>"; //
6262

6363
assertThat(new Bxml().with(transfer1).toBxml(jaxbContext), is(expectedSipUriBxml));
6464
assertThat(new Bxml().with(transfer2).toBxml(jaxbContext), is(expectedPhoneNumberBxml));

0 commit comments

Comments
 (0)