Skip to content

Commit 1375996

Browse files
committed
Fix registry login condition in workflow
1 parent b5fa858 commit 1375996

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/cicd.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ on:
88
env:
99
IMAGE_NAME: algorithm-blog
1010
REGISTRY_HOST: ${{ secrets.REGISTRY_HOST }}
11+
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
12+
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
1113

1214
jobs:
1315
build-and-push:
@@ -21,7 +23,7 @@ jobs:
2123
uses: docker/setup-buildx-action@v3
2224

2325
- name: Login to registry (optional)
24-
if: ${{ secrets.REGISTRY_USERNAME != '' && secrets.REGISTRY_PASSWORD != '' }}
26+
if: ${{ env.REGISTRY_USERNAME != '' && env.REGISTRY_PASSWORD != '' }}
2527
uses: docker/login-action@v3
2628
with:
2729
registry: ${{ env.REGISTRY_HOST }}

deploy/cicd.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ on:
88
env:
99
IMAGE_NAME: algorithm-blog
1010
REGISTRY_HOST: ${{ secrets.REGISTRY_HOST }}
11+
REGISTRY_USERNAME: ${{ secrets.REGISTRY_USERNAME }}
12+
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
1113

1214
jobs:
1315
build-and-push:
@@ -21,7 +23,7 @@ jobs:
2123
uses: docker/setup-buildx-action@v3
2224

2325
- name: Login to registry (optional)
24-
if: ${{ secrets.REGISTRY_USERNAME != '' && secrets.REGISTRY_PASSWORD != '' }}
26+
if: ${{ env.REGISTRY_USERNAME != '' && env.REGISTRY_PASSWORD != '' }}
2527
uses: docker/login-action@v3
2628
with:
2729
registry: ${{ env.REGISTRY_HOST }}

0 commit comments

Comments
 (0)