Use walrus assignment consistently

Author: NathanBaulch

CHANGELOG.md

@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Style
+- Use walrus assignment where possible.
 
 ## [v7.10.0] - 2025-10-07
 ### Security

backend/azure/fileSystem_test.go

@@ -122,11 +122,11 @@ func (s *FileSystemTestSuite) TestScheme() {
 }
 
 func (s *FileSystemTestSuite) TestRetry() {
-	var doNothing = func() error {
+	doNothing := func() error {
 		return nil
 	}
 
-	var errorRetry = func(wrapped func() error) error {
+	errorRetry := func(wrapped func() error) error {
 		return errors.New("i always error")
 	}
 

backend/ftp/file_test.go

@@ -73,7 +73,7 @@ func (ts *fileTestSuite) TestRead() {
 		path: fp,
 	}
 	// test successful read
-	var localFile = bytes.NewBuffer([]byte{})
+	localFile := bytes.NewBuffer([]byte{})
 	b, copyErr := io.Copy(localFile, ftpfile)
 	ts.Require().NoError(copyErr, "no error expected")
 	ts.Len(contents, int(b), "byte count after copy")
@@ -217,7 +217,7 @@ func (ts *fileTestSuite) TestSeek() {
 	// seek to position 6, whence 0
 	_, err = ftpfile.Seek(6, 0)
 	ts.Require().NoError(err, "no error expected")
-	var localFile = bytes.NewBuffer([]byte{})
+	localFile := bytes.NewBuffer([]byte{})
 	_, err = io.Copy(localFile, ftpfile)
 	ts.Require().NoError(err, "no error expected")
 	ts.Equal("world!", localFile.String(), "Seeking should move the ftp file cursor as expected")

backend/ftp/location.go

@@ -57,7 +57,7 @@ func (l *Location) List() ([]string, error) {
 //   - If the user cares about the distinction between an empty location and a non-existent one, Location.Exists() should
 //     be checked first.
 func (l *Location) ListByPrefix(prefix string) ([]string, error) {
-	var filenames = make([]string, 0)
+	filenames := make([]string, 0)
 
 	// validate prefix
 	if err := utils.ValidatePrefix(prefix); err != nil {

backend/ftp/options_test.go

@@ -166,8 +166,8 @@ func (s *optionsSuite) TestFetchHostPortString() {
 }
 
 func (s *optionsSuite) TestIsDisableEPSV() {
-	var trueVal = true
-	var falseVal = false
+	trueVal := true
+	falseVal := false
 	tests := []struct {
 		description string
 		options     Options

backend/gs/file_test.go

@@ -101,7 +101,7 @@ func (ts *fileTestSuite) TestRead() {
 	file, err := fs.NewFile(bucketName, "/"+objectName)
 	ts.Require().NoError(err, "Shouldn't fail creating new file")
 
-	var localFile = bytes.NewBuffer([]byte{})
+	localFile := bytes.NewBuffer([]byte{})
 
 	buffer := make([]byte, utils.TouchCopyMinBufferSize)
 	_, copyErr := io.CopyBuffer(localFile, file, buffer)

backend/os/file_test.go

@@ -324,7 +324,7 @@ func (s *osFileTest) TestSafeOsRename() {
 	testfile := path.Join(dir, "original.txt")
 	file1, err := s.fileSystem.NewFile("", testfile)
 	s.Require().NoError(err)
-	var testBytes = []byte("test me")
+	testBytes := []byte("test me")
 	_, err = file1.Write(testBytes)
 	s.Require().NoError(err)
 	s.Require().NoError(file1.Close())
@@ -354,7 +354,7 @@ func (s *osFileTest) TestOsCopy() {
 
 	file1, err := s.fileSystem.NewFile("", path.Join(dir, "original.txt"))
 	s.Require().NoError(err)
-	var testBytes = []byte("test me")
+	testBytes := []byte("test me")
 	_, err = file1.Write(testBytes)
 	s.Require().NoError(err)
 	s.Require().NoError(file1.Close())

backend/s3/file.go

@@ -681,7 +681,7 @@ func waitUntilFileExists(file vfs.File, retries int) error {
 	if retries == -1 {
 		return nil
 	}
-	var retryCount = 0
+	retryCount := 0
 	for {
 		if retryCount == retries {
 			return fmt.Errorf("failed to find file %s after %d retries", file, retries)

backend/s3/file_test.go

@@ -60,7 +60,7 @@ func (ts *fileTestSuite) TestRead() {
 	file, err := fs.NewFile("bucket", "/some/path/file.txt")
 	ts.Require().NoError(err, "Shouldn't fail creating new file")
 
-	var localFile = bytes.NewBuffer([]byte{})
+	localFile := bytes.NewBuffer([]byte{})
 	s3cliMock.
 		On("HeadObject", matchContext, mock.AnythingOfType("*s3.HeadObjectInput")).
 		Return(&s3.HeadObjectOutput{ContentLength: aws.Int64(12)}, nil).

backend/sftp/file_test.go

@@ -64,7 +64,7 @@ func (ts *fileTestSuite) TestRead() {
 		sftpfile: &nopWriteCloser{strings.NewReader(contents)},
 	}
 	// perform test
-	var localFile = bytes.NewBuffer([]byte{})
+	localFile := bytes.NewBuffer([]byte{})
 
 	buffer := make([]byte, utils.TouchCopyMinBufferSize)
 	b, copyErr := io.CopyBuffer(localFile, sftpfile, buffer)
@@ -98,7 +98,7 @@ func (ts *fileTestSuite) TestSeek() {
 	_, seekErr := sftpfile.Seek(6, 0)
 	ts.Require().NoError(seekErr, "no error expected")
 
-	var localFile = bytes.NewBuffer([]byte{})
+	localFile := bytes.NewBuffer([]byte{})
 
 	buffer := make([]byte, utils.TouchCopyMinBufferSize)
 	_, copyErr := io.CopyBuffer(localFile, sftpfile, buffer)