Fixed a bug by synchronize being called at the wrong time

Author: jmwright

assembly_mesh_plugin/plugin.py

@@ -204,21 +204,21 @@ def get_gmsh(self, imprint=True):
 
     # Step through each of the volumes and add physical groups for each
     for volume_id in volumes.keys():
+        gmsh.model.occ.synchronize()
         ps = gmsh.model.addPhysicalGroup(3, volumes[volume_id][0])
         gmsh.model.setPhysicalName(3, ps, f"{volume_map[volume_id]}")
-        gmsh.model.occ.synchronize()
 
     # Handle tagged surface groups
     for t_name, surf_group in surface_groups.items():
+        gmsh.model.occ.synchronize()
         ps = gmsh.model.addPhysicalGroup(2, surf_group)
         gmsh.model.setPhysicalName(2, ps, t_name)
-        gmsh.model.occ.synchronize()
 
     # Handle multi-material tags
     for group_name, mm_group in multi_material_groups.items():
+        gmsh.model.occ.synchronize()
         ps = gmsh.model.addPhysicalGroup(2, mm_group)
         gmsh.model.setPhysicalName(2, ps, f"{group_name}")
-        gmsh.model.occ.synchronize()
 
     gmsh.model.occ.synchronize()
 

tests/test_meshes.py

@@ -141,8 +141,8 @@ def _check_physical_groups():
         # Make sure that there are physical groups for the volumes
         physical_groups = gmsh.model.getPhysicalGroups(3)
         assert (
-            len(physical_groups) > 0
-        ), "There should be some physical groups for volumes"
+            len(physical_groups) == 2
+        ), "There should be two physical groups for volumes"
 
         # Check the solids for the correct tags
         for group in physical_groups:
@@ -151,6 +151,10 @@ def _check_physical_groups():
 
             assert cur_name in ["inner_sphere", "middle_sphere"]
 
+        # Make sure we can retrieve the physical groups
+        inner_sphere_volume = gmsh.model.getEntitiesForPhysicalName("inner_sphere")
+        middle_sphere_volume = gmsh.model.getEntitiesForPhysicalName("middle_sphere")
+
     # Create a basic assembly
     assy = generate_nested_spheres()