Skip to content

Commit 8b181ac

Browse files
fix: address code review feedback
- fix(rust): remove trailing separator in module path construction - fix(version): correct package name from baml-py to baml-rs for Rust installs - docs(go): fix variable name inconsistency in FFI example Resolves PR feedback from ellipsis-dev bot.
1 parent 7e0645e commit 8b181ac

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

BAML-GO.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func CallFunctionStreamFromC(runtime unsafe.Pointer, functionName string, encode
6464
cFunctionName := C.CString(functionName)
6565
defer C.free(unsafe.Pointer(cFunctionName))
6666

67-
result := C.WrapCallFunctionStreamFromC(runtime, cFunctionName, cEncodedArgs, C.uintptr_t(len(encodedArgs)), C.uint32_t(id))
67+
result := C.WrapCallFunctionStreamFromC(runtime, cFunctionName, encodedArgs, C.uintptr_t(len(encodedArgs)), C.uint32_t(id))
6868
return result, nil
6969
}
7070

engine/generators/languages/rust/src/package.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,16 @@ impl Package {
2929
return "".to_string();
3030
}
3131

32-
// Convert baml_client.types to crate::types::
32+
// Convert baml_client.types to crate::types
3333
let mut path = String::new();
3434
for (i, part) in self.package_path.iter().enumerate() {
3535
if i == 0 && part == "baml_client" {
36-
path.push_str("crate::");
36+
path.push_str("crate");
3737
} else if i > 0 {
3838
path.push_str(part);
39+
}
40+
// Only add separator if there's another part coming
41+
if i < self.package_path.len() - 1 {
3942
path.push_str("::");
4043
}
4144
}

engine/language_client_codegen/src/version_check.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ pub fn check_version(
114114
format!("go install github.com/boundaryml/baml/go@{gen_version}")
115115
}
116116
GeneratorOutputType::Rust => {
117-
format!("cargo install baml-py --version {gen_version}")
117+
format!("cargo install baml-rs --version {gen_version}")
118118
}
119119
};
120120
(

0 commit comments

Comments
 (0)