Feature/sealed enum support #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocohead
reviewed
Mar 28, 2023
LlamaLad7
force-pushed
the
feature/sealed-enum-support
branch
2 times, most recently
from
70b0645 to
0950e15
Compare
We need ASM >=9 for this PR. The other stuff just seems to have broken over time.
LlamaLad7
force-pushed
the
feature/sealed-enum-support
branch
from
0950e15 to
11edbe4
Compare
|
@Chocohead I understand this project hasn't seen much action lately, but this specific issue would be very nice to have solved. Is anything missing for this PR to be approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin. Enum subclass extensions are currently broken on Java 16+