Skip to content

Commit d53ac66

Browse files
szuenddevtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com
authored andcommitted
[gn] Deduplicate grd inputs in generate_devtools_grd action
Deduplicate the iteration over `_expected_grd_files` in the `generate_devtools_grd` action inputs by hoisting it outside the `is_debug` condition. Bug: None Change-Id: I5b2c07d1f77e4715666e84929743d63df23e8650 TAG=agy CONV=edc30b47-127d-42af-90d9-8a14eb4093c6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8278420 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
1 parent 103a382 commit d53ac66

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

BUILD.gn

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,17 +168,14 @@ action("generate_devtools_grd") {
168168
]
169169

170170
inputs = []
171+
foreach(_grd_file, _expected_grd_files) {
172+
inputs += [ "$target_gen_dir/$_grd_file" ]
173+
}
171174

172175
if (is_debug) {
173176
deps = [ ":devtools_frontend_resources" ]
174-
foreach(_grd_file, _expected_grd_files) {
175-
inputs += [ "$target_gen_dir/$_grd_file" ]
176-
}
177177
} else {
178178
deps = [ ":compress" ]
179-
foreach(_grd_file, _expected_grd_files) {
180-
inputs += [ "$target_gen_dir/$_grd_file" ]
181-
}
182179
foreach(_grd_file, _compressable_grd_files) {
183180
inputs += [ "$target_gen_dir/$_grd_file.compressed" ]
184181
}

0 commit comments

Comments
 (0)