Skip to content

Commit 5d48f52

Browse files
committed
update java 11 src
1 parent 6ce419c commit 5d48f52

File tree

4 files changed

+19
-9
lines changed

4 files changed

+19
-9
lines changed

clickhouse-http-client/src/main/java11/com/clickhouse/client/http/ClickHouseHttpConnectionFactory.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
import java.io.IOException;
44
import java.util.concurrent.ExecutorService;
5+
import java.util.Collections;
6+
import java.io.Serializable;
7+
import java.util.Map;
8+
59

610
import com.clickhouse.client.ClickHouseNode;
711
import com.clickhouse.client.ClickHouseRequest;
@@ -14,7 +18,13 @@ public final class ClickHouseHttpConnectionFactory {
1418
private static final Logger log = LoggerFactory.getLogger(ClickHouseHttpConnectionFactory.class);
1519

1620
public static ClickHouseHttpConnection createConnection(ClickHouseNode server, ClickHouseRequest<?> request,
17-
ExecutorService executor) throws IOException {
21+
ExecutorService executor) throws IOException
22+
{
23+
return createConnection(server, request, executor, Collections.emptyMap());
24+
}
25+
26+
public static ClickHouseHttpConnection createConnection(ClickHouseNode server, ClickHouseRequest<?> request,
27+
ExecutorService executor, Map<String, Serializable> additionalRequestParams) throws IOException {
1828
HttpConnectionProvider provider = request.getConfig().getOption(ClickHouseHttpOption.CONNECTION_PROVIDER,
1929
HttpConnectionProvider.class);
2030
if (provider == HttpConnectionProvider.APACHE_HTTP_CLIENT) {
@@ -24,10 +34,10 @@ public static ClickHouseHttpConnection createConnection(ClickHouseNode server, C
2434
log.warn("Error when creating %s, fall back to HTTP_URL_CONNECTION", provider, t);
2535
}
2636
} else if (provider == HttpConnectionProvider.HTTP_CLIENT) {
27-
return new HttpClientConnectionImpl(server, request, executor);
37+
return new HttpClientConnectionImpl(server, request, executor, additionalRequestParams);
2838
}
2939

30-
return new HttpUrlConnectionImpl(server, request, executor);
40+
return new HttpUrlConnectionImpl(server, request, executor, additionalRequestParams);
3141
}
3242

3343
private ClickHouseHttpConnectionFactory() {

clickhouse-http-client/src/main/java11/com/clickhouse/client/http/HttpClientConnectionImpl.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252
import java.util.concurrent.ExecutionException;
5353
import java.util.concurrent.ExecutorService;
5454
import java.util.concurrent.atomic.AtomicBoolean;
55+
import java.io.Serializable;
56+
import java.util.Map;
5557

5658
import javax.net.ssl.SSLContext;
5759

@@ -173,9 +175,9 @@ private HttpRequest newRequest(String url) {
173175
.timeout(Duration.ofMillis(config.getSocketTimeout())).build();
174176
}
175177

176-
protected HttpClientConnectionImpl(ClickHouseNode server, ClickHouseRequest<?> request, ExecutorService executor)
177-
throws IOException {
178-
super(server, request);
178+
protected HttpClientConnectionImpl(ClickHouseNode server, ClickHouseRequest<?> request, ExecutorService executor,
179+
Map<String, Serializable> additionalParams) throws IOException {
180+
super(server, request, additionalParams);
179181

180182
HttpClient.Builder builder = HttpClient.newBuilder().version(Version.HTTP_1_1)
181183
.connectTimeout(Duration.ofMillis(config.getConnectionTimeout())).followRedirects(Redirect.NORMAL);

clickhouse-jdbc/src/main/javacc/ClickHouseSqlParser.jj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,6 @@ public class ClickHouseSqlParser {
143143
for (int i = anyArgsListStart; i < stmtLength; i++) {
144144
char ch = token_source.builder.charAt(i);
145145
if (ch == '"' && isQuoted ) {
146-
roles.add(roleBuff.toString());
147-
roleBuff.setLength(0);
148146
isQuoted = false;
149147
} else if (ch == '"') {
150148
isQuoted = true;

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/AccessManagementTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private static Object[][] setRolesArgsForTestSetRole() {
6969
HttpConnectionProvider.APACHE_HTTP_CLIENT.name()},
7070
{new String[]{"ROL1", "\"ROL2,☺\""}, "set role \"ROL2,☺\", ROL1", new String[]{"ROL2,☺", "ROL1"},
7171
HttpConnectionProvider.APACHE_HTTP_CLIENT.name()},
72-
{new String[]{"ROL1", "ROL2"}, "set role ROL2 , ROL1, ", new String[]{"ROL", "ROL1"},
72+
{new String[]{"ROL1", "ROL2"}, "set role ROL2 , ROL1 ", new String[]{"ROL2", "ROL1"},
7373
HttpConnectionProvider.APACHE_HTTP_CLIENT.name()},
7474
};
7575
}

0 commit comments

Comments
 (0)