Skip to content

Commit cb8e198

Browse files
mzitnikmzitnik
andauthored
Deprication of ClickHouse GRPC Client (#1522)
Co-authored-by: mzitnik <[email protected]>
1 parent 52634fb commit cb8e198

14 files changed

+22
-18
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
### WARNING -- ClickHouse CLI Client deprecation
55
`clickhouse-cli-client` package is deprecated from version 0.6.0 and it's going to be removed in `0.7.0`. We recommend using [clickhouse-client](https://clickhouse.com/docs/en/interfaces/cli) instead.
66

7+
### WARNING -- ClickHouse GRPC Client deprecation
8+
`clickhouse-grpc-client` package is deprecated from version 0.6.0 and it's going to be removed in `0.7.0`. We recommend using [HTTP](https://github.com/ClickHouse/clickhouse-java/blob/main/examples/client/src/main/java/com/clickhouse/examples/jdbc/Main.java) protocol instead.
9+
710
## 0.5.0
811
### Breaking Changes
912
* ClickHouseByteBuffer can no longer be extended

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ Java libraries for connecting to ClickHouse and processing data in various forma
99
## Features
1010

1111
| Category | Feature | Supported | Remark |
12-
| ----------------- | ----------------------------------------------------------------------------------- | ------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
12+
| ----------------- | ----------------------------------------------------------------------------------- | ------------------ |--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
1313
| API | [JDBC](https://docs.oracle.com/javase/8/docs/technotes/guides/jdbc/) | :white_check_mark: | |
1414
| | [R2DBC](https://r2dbc.io/) | :white_check_mark: | supported since 0.4.0 |
1515
| Protocol | [HTTP](https://clickhouse.com/docs/en/interfaces/http/) | :white_check_mark: | recommended, defaults to `java.net.HttpURLConnection` and it can be changed to `java.net.http.HttpClient`(unstable) or `Apache HTTP Client 5`. Note that the latter was added in 0.4.0 to support custom socket options. |
16-
| | [gRPC](https://clickhouse.com/docs/en/interfaces/grpc/) | :white_check_mark: | :warning: experimental, works with 22.3+, known to has issue with lz4 compression and may cause high memory usage on server |
17-
| | [TCP/Native](https://clickhouse.com/docs/en/interfaces/tcp/) | :x: | `clickhouse-cli-client`(wrapper of ClickHouse native command-line client) was added in 0.3.2-patch10. |
16+
| | [gRPC](https://clickhouse.com/docs/en/interfaces/grpc/) | :white_check_mark: | :warning: experimental, works with 22.3+, known to has issue with lz4 compression and may cause high memory usage on server. Planed to be removed from version 0.7.0 |
17+
| | [TCP/Native](https://clickhouse.com/docs/en/interfaces/tcp/) | :x: | `clickhouse-cli-client`(wrapper of ClickHouse native command-line client) was added in 0.3.2-patch10. |
1818
| | [Local/File](https://clickhouse.com/docs/en/operations/utilities/clickhouse-local/) | :x: | `clickhouse-cli-client` will be enhanced to support `clickhouse-local` |
1919
| Compatibility | Server < 20.7 | :x: | use 0.3.1-patch(or 0.2.6 if you're stuck with JDK 7) |
2020
| | Server >= 20.7 | :white_check_mark: | use 0.3.2 or above. All [active releases](https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease) are supported. |
@@ -51,10 +51,10 @@ Java libraries for connecting to ClickHouse and processing data in various forma
5151

5252
## Planed to be removed
5353

54-
| Feature | Version | Remark |
55-
|--------------------------------|---------|----------------------------------------|
56-
| Clickhouse ClI Client package | 0.7.0 | Use clickhouse-client directly instead |
57-
54+
| Feature | Version | Remark |
55+
|--------------------------------|---------|--------------------------------------------------|
56+
| Clickhouse ClI Client package | 0.7.0 | Use clickhouse-client directly instead |
57+
| ClickHouse GRPC Client package | 0.7.0 | Please use the clickhouse http protocol instead |
5858
## Usage
5959

6060
The library can be downloaded from both [Github Releases](../../releases) and [Maven Central](https://repo1.maven.org/maven2/com/clickhouse/). Development snapshots(aka. nightly build) are available on [Sonatype OSSRH](https://s01.oss.sonatype.org/content/repositories/snapshots/com/clickhouse/).

clickhouse-grpc-client/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<packaging>jar</packaging>
1414

1515
<name>ClickHouse gRPC Client</name>
16-
<description>gRPC client for ClickHouse</description>
16+
<description>gRPC client for ClickHouse planed to be deprecated from version 0.6.0 and removed at 0.7.0</description>
1717
<url>https://github.com/ClickHouse/clickhouse-java/tree/main/clickhouse-grpc-client</url>
1818

1919
<dependencies>

clickhouse-grpc-client/src/main/java/com/clickhouse/client/grpc/ClickHouseGrpcChannelFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import com.clickhouse.data.ClickHouseUtils;
2828
import com.clickhouse.logging.Logger;
2929
import com.clickhouse.logging.LoggerFactory;
30-
30+
@Deprecated
3131
public abstract class ClickHouseGrpcChannelFactory {
3232
static class NoProxyDetector implements ProxyDetector {
3333
static final NoProxyDetector INSTANCE = new NoProxyDetector();

clickhouse-grpc-client/src/main/java/com/clickhouse/client/grpc/ClickHouseGrpcClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import com.clickhouse.client.UnsupportedProtocolException;
1313
import com.clickhouse.client.grpc.config.ClickHouseGrpcOption;
1414
import com.clickhouse.config.ClickHouseOption;
15-
15+
@Deprecated
1616
public class ClickHouseGrpcClient implements ClickHouseClient {
1717
private final AtomicReference<ClickHouseClient> ref;
1818

clickhouse-grpc-client/src/main/java/com/clickhouse/client/grpc/ClickHouseGrpcClientImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
import com.clickhouse.data.ClickHouseUtils;
4848
import com.clickhouse.logging.Logger;
4949
import com.clickhouse.logging.LoggerFactory;
50-
50+
@Deprecated
5151
public class ClickHouseGrpcClientImpl extends AbstractClient<ManagedChannel> {
5252
private static final Logger log = LoggerFactory.getLogger(ClickHouseGrpcClientImpl.class);
5353

clickhouse-grpc-client/src/main/java/com/clickhouse/client/grpc/ClickHouseGrpcResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import com.clickhouse.client.grpc.impl.Result;
1515
import com.clickhouse.client.grpc.impl.Stats;
1616
import com.clickhouse.data.ClickHouseInputStream;
17-
17+
@Deprecated
1818
public class ClickHouseGrpcResponse extends ClickHouseStreamResponse {
1919
private final transient ClickHouseStreamObserver observer;
2020

clickhouse-grpc-client/src/main/java/com/clickhouse/client/grpc/ClickHouseStreamObserver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import com.clickhouse.data.ClickHouseUtils;
2929
import com.clickhouse.logging.Logger;
3030
import com.clickhouse.logging.LoggerFactory;
31-
31+
@Deprecated
3232
public class ClickHouseStreamObserver implements StreamObserver<Result> {
3333
private static final Logger log = LoggerFactory.getLogger(ClickHouseStreamObserver.class);
3434

clickhouse-grpc-client/src/main/java/com/clickhouse/client/grpc/FramedLZ4Utils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import java.io.IOException;
44
import java.io.InputStream;
55
import java.io.OutputStream;
6-
6+
@Deprecated
77
final class FramedLZ4Utils {
88
static InputStream wrap(InputStream input) throws IOException {
99
return new org.apache.commons.compress.compressors.lz4.FramedLZ4CompressorInputStream(input);

clickhouse-grpc-client/src/main/java/com/clickhouse/client/grpc/NettyChannelFactoryImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import com.clickhouse.client.grpc.config.ClickHouseGrpcOption;
1919
import com.clickhouse.data.ClickHouseChecker;
2020
import com.clickhouse.data.ClickHouseUtils;
21-
21+
@Deprecated
2222
final class NettyChannelFactoryImpl extends ClickHouseGrpcChannelFactory {
2323
private static final String USER_AGENT = ClickHouseClientOption.buildUserAgent(null, "gRPC-Netty");
2424

0 commit comments

Comments
 (0)