Skip to content

Commit 81fe03f

Browse files
committed
update review skill
1 parent 3ddc415 commit 81fe03f

File tree

1 file changed

+7
-1
lines changed
  • .claude/skills/review-implementation

1 file changed

+7
-1
lines changed

.claude/skills/review-implementation/SKILL.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ Read the implementation files and assess:
9797
3. **Example quality** -- Is it tutorial-style? Does it use the instance from the issue? Does the JSON export include both source and target data?
9898
4. **Paper quality** -- Is the reduction-rule statement precise? Is the proof sketch sound? Is the example figure clear?
9999

100+
### Code Quality Principles (applies to both Models and Rules):
101+
1. **DRY (Don't Repeat Yourself)** -- Is there duplicated logic that should be extracted into a shared helper, utility function, or common module? Check for copy-pasted code blocks across files (e.g., similar graph construction, weight handling, or solution extraction patterns). If duplication is found, suggest extracting shared logic.
102+
2. **KISS (Keep It Simple, Stupid)** -- Is the implementation unnecessarily complex? Look for: over-engineered abstractions, convoluted control flow, premature generalization, or layers of indirection that add no value. The implementation should be as simple as possible while remaining correct and maintainable.
103+
100104
## Output Format
101105

102106
Present results as:
@@ -119,7 +123,9 @@ Present results as:
119123
### Semantic Review
120124
- evaluate() correctness: OK
121125
- dims() correctness: OK
122-
- [any issues found]
126+
- DRY compliance: OK / [duplicated logic found in ...]
127+
- KISS compliance: OK / [unnecessary complexity found in ...]
128+
- [any other issues found]
123129
124130
### Summary
125131
- X/Y structural checks passed

0 commit comments

Comments
 (0)