From 6835d75c8c4b4a904edfea07cc44ca8ef8c9b0b8 Mon Sep 17 00:00:00 2001 From: Matz Reckeweg Date: Fri, 12 Sep 2025 11:22:46 +0200 Subject: [PATCH] Support null values in NumericValidationBehavior --- .../Behaviors/NumericValidationBehaviorTests.cs | 6 +++++- .../Validators/NumericValidationBehavior.shared.cs | 2 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/CommunityToolkit.Maui.UnitTests/Behaviors/NumericValidationBehaviorTests.cs b/src/CommunityToolkit.Maui.UnitTests/Behaviors/NumericValidationBehaviorTests.cs index a13e7158f1..c7a73b11f2 100644 --- a/src/CommunityToolkit.Maui.UnitTests/Behaviors/NumericValidationBehaviorTests.cs +++ b/src/CommunityToolkit.Maui.UnitTests/Behaviors/NumericValidationBehaviorTests.cs @@ -85,8 +85,12 @@ public async Task IsNull() Text = text }; entry.Behaviors.Add(behavior); + + //Act + await behavior.ForceValidate(TestContext.Current.CancellationToken); - await Assert.ThrowsAsync(async () => await behavior.ForceValidate(TestContext.Current.CancellationToken)); + // Assert + Assert.False(behavior.IsValid); } [Fact(Timeout = (int)TestDuration.Short)] diff --git a/src/CommunityToolkit.Maui/Behaviors/Validators/NumericValidationBehavior.shared.cs b/src/CommunityToolkit.Maui/Behaviors/Validators/NumericValidationBehavior.shared.cs index c8caf6722d..ad12c4f1ae 100644 --- a/src/CommunityToolkit.Maui/Behaviors/Validators/NumericValidationBehavior.shared.cs +++ b/src/CommunityToolkit.Maui/Behaviors/Validators/NumericValidationBehavior.shared.cs @@ -76,8 +76,6 @@ public int MaximumDecimalPlaces /// protected override ValueTask ValidateAsync(string? value, CancellationToken token) { - ArgumentNullException.ThrowIfNull(value); - if (!(double.TryParse(value, out var numeric) && numeric >= MinimumValue && numeric <= MaximumValue))