EthApi Interface - new eth methods - #1584
Merged
Merged
Conversation
Filter94
reviewed
Oct 20, 2025
fluentcrafter
force-pushed
the
eth-api-pt-2
branch
from
November 18, 2025 11:51
1f24a61 to
2685cc6
Compare
Filter94
approved these changes
Nov 19, 2025
gauravahuja
reviewed
Nov 19, 2025
gauravahuja
left a comment
Contributor
There was a problem hiding this comment.
Just the one comment, otherwise LGTM
jonesho
pushed a commit
that referenced
this pull request
Nov 24, 2025
#1584) * skip ref test that are deployment transaction to an already existing account (code or nonce) Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch> * missing the g1v1 * one more --------- Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch> Co-authored-by: FlorianHuc <florian.huc@gmail.com>
jonesho
pushed a commit
that referenced
this pull request
Dec 8, 2025
#1584) * skip ref test that are deployment transaction to an already existing account (code or nonce) Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch> * missing the g1v1 * one more --------- Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch> Co-authored-by: FlorianHuc <florian.huc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #1577
Checklist
Note
Refactors EthApi into modular interfaces with many new eth_* methods, implements them in Web3j clients (with retries), adds domain models/mappers, and updates coordinator and log searcher to new APIs.
EthApiClientinto modular interfaces:EthApiChainIdClient,EthApiFeeClient,EthApiSimulationClient,EthApiBlockClient,EthLogsClient,EthApiAccountClient,EthApiTransactionClient,EthApiExecutionClientInfo.ethChainId,ethBlockNumber, block getters (ethFind/GetBlockByNumber{FullTxs,TxHashes}), account (ethGetBalance,ethGetTransactionCount), fees (ethGasPrice,ethMaxPriorityFeePerGas,ethFeeHistory), txs (ethGetTransactionByHash,ethGetTransactionReceipt,ethSendRawTransaction), node info (ethProtocolVersion,ethCoinbase,ethMining), simulation (ethCall,ethEstimateGas).TransactionForEthCallandTransactionReceiptmodels; add mappers (TransactionForEthCallMapper,TransactionReceiptMapper).Web3jEthApiClientimplements new methods;Web3jEthApiClientWithRetrieswraps them with tailored retry predicates (incl. execution-reverted stop).EthLogsClientaddsFilterOptions+ethGetLogshelper.FakeEthApiClientupdated to new interface/methods.getChainId()withethChainId()andgetBlockByNumberWithoutTransactionsData()withethGetBlockByNumberTxHashes()in coordinator components and log searcher.ethGetBlockByNumber{FullTxs,TxHashes}) and behaviors.Written by Cursor Bugbot for commit edcdd26. This will update automatically on new commits. Configure here.