fix(chat): handle empty prompt and tools before ask (#1258)

Move the check for empty prompt and resolved tools before making the ask
call. This ensures that unnecessary user messages are removed and the
finish callback is called early, preventing redundant processing. Also
remove assistant message if all tool calls are handled.

Signed-off-by: Tomas Slusny <[email protected]>

Author: deathbeam

lua/CopilotChat/init.lua

@@ -969,10 +969,17 @@ function M.ask(prompt, config)
     end
 
     prompt = vim.trim(prompt)
+    utils.schedule_main()
 
-    if not config.headless then
-      utils.schedule_main()
+    if utils.empty(prompt) and utils.empty(resolved_tools) then
+      if not config.headless then
+        M.chat:remove_message('user')
+        finish()
+      end
+      return
+    end
 
+    if not config.headless then
       -- Remove any tool calls that we did not handle
       local assistant_message = M.chat:get_message('assistant')
       if assistant_message and assistant_message.tool_calls then
@@ -987,6 +994,10 @@ function M.ask(prompt, config)
             return handled_ids[tool_call.id]
           end)
           :totable()
+
+        if utils.empty(assistant_message.tool_calls) then
+          M.chat:remove_message('assistant')
+        end
       end
 
       if not utils.empty(resolved_tools) then
@@ -1009,14 +1020,6 @@ function M.ask(prompt, config)
       end
     end
 
-    if utils.empty(prompt) and utils.empty(resolved_tools) then
-      if not config.headless then
-        M.chat:remove_message('user')
-        finish()
-      end
-      return
-    end
-
     local ask_ok, ask_response = pcall(client.ask, client, prompt, {
       headless = config.headless,
       history = M.chat.messages,