Merge pull request #144 from CoreyKaylor/fix-enumerable

CoreyKaylor · web-flow · commit 6c5e3df61c3e · 2021-09-06T05:23:05.000-07:00
Fix AsEnumerable silent failure
diff --git a/src/LightningDB/LightningExtensions.cs b/src/LightningDB/LightningExtensions.cs
@@ -64,14 +64,12 @@ private static string mdb_strerror(int err)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static IEnumerable<ValueTuple<MDBValue, MDBValue>> AsEnumerable(this LightningCursor cursor)
         {
-            do
+            while(cursor.Next() == MDBResultCode.Success)
             {
                 var (resultCode, key, value) = cursor.GetCurrent();
-                if (resultCode == MDBResultCode.Success)
-                {
-                    yield return (key, value);
-                }
-            } while (cursor.Next() == MDBResultCode.Success);
+                resultCode.ThrowOnError();
+                yield return (key, value);
+            }
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -64,14 +64,12 @@ private static string mdb_strerror(int err)`
`64`	`64`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`65`	`65`	`public static IEnumerable<ValueTuple<MDBValue, MDBValue>> AsEnumerable(this LightningCursor cursor)`
`66`	`66`	`{`
`67`		`- do`
	`67`	`+ while(cursor.Next() == MDBResultCode.Success)`
`68`	`68`	`{`
`69`	`69`	`var (resultCode, key, value) = cursor.GetCurrent();`
`70`		`- if (resultCode == MDBResultCode.Success)`
`71`		`- {`
`72`		`- yield return (key, value);`
`73`		`- }`
`74`		`- } while (cursor.Next() == MDBResultCode.Success);`
	`70`	`+ resultCode.ThrowOnError();`
	`71`	`+ yield return (key, value);`
	`72`	`+ }`
`75`	`73`	`}`
`76`	`74`
`77`	`75`	`/// <summary>`