Fix lint warnings, crash

Signed-off-by: PranavPurwar <[email protected]>

Author: PranavPurwar

app/build.gradle.kts

@@ -63,6 +63,8 @@ android {
         enable = true
     }
 
+    lint.abortOnError = false
+
     configurations.configureEach {
         exclude(group = "javax.inject", module = "javax.inject")
         exclude(group = "org.jetbrains", module = "annotations-java5")

app/src/main/AndroidManifest.xml

@@ -14,6 +14,7 @@
         tools:ignore="ScopedStorage" />
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
     <uses-permission
         android:name="android.permission.QUERY_ALL_PACKAGES"
         tools:ignore="QueryAllPackagesPermission" />

app/src/main/kotlin/org/cosmicide/rewrite/App.kt

@@ -32,7 +32,6 @@ import org.cosmicide.rewrite.plugin.api.PluginLoader
 import org.cosmicide.rewrite.util.CommonUtils
 import org.cosmicide.rewrite.util.FileUtil
 import org.eclipse.tm4e.core.registry.IThemeSource
-import org.jetbrains.kotlin.utils.addToStdlib.ifTrue
 import org.lsposed.hiddenapibypass.HiddenApiBypass
 import rikka.sui.Sui
 import java.io.File
@@ -60,11 +59,15 @@ class App : Application() {
 
     override fun onCreate() {
         super.onCreate()
+
+        if (FileUtil.isInitialized.not()) return
+
         Sui.init(packageName)
         instance = WeakReference(this)
         HookManager.context = WeakReference(this)
 
         setupHooks()
+
         loadPlugins()
 
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {

app/src/main/kotlin/org/cosmicide/rewrite/MainActivity.kt

@@ -21,6 +21,7 @@ import androidx.core.view.WindowInsetsCompat
 import androidx.core.view.updateLayoutParams
 import androidx.fragment.app.commit
 import androidx.lifecycle.lifecycleScope
+import com.google.android.material.color.DynamicColors
 import com.kieronquinn.app.darq.utils.extensions.awaitBinderReceived
 import com.kieronquinn.app.darq.utils.extensions.isShizukuInstalled
 import kotlinx.coroutines.launch
@@ -49,6 +50,7 @@ class MainActivity : AppCompatActivity() {
         val accent = Prefs.appAccent
             themeInt = CommonUtils.getAccent(accent)
             setTheme(themeInt)
+        DynamicColors.applyToActivityIfAvailable(this)
         enableEdgeToEdge()
         return super.onCreateView(parent, name, context, attrs)
     }

app/src/main/kotlin/org/cosmicide/rewrite/adapter/GitAdapter.kt

@@ -7,6 +7,7 @@
 
 package org.cosmicide.rewrite.adapter
 
+import android.annotation.SuppressLint
 import android.view.ViewGroup
 import android.widget.TextView
 import androidx.recyclerview.widget.RecyclerView
@@ -42,9 +43,10 @@ class GitAdapter : RecyclerView.Adapter<GitAdapter.ViewHolder>() {
         val textView: TextView
     ) : RecyclerView.ViewHolder(textView) {
 
+        @SuppressLint("SetTextI18n")
         fun bind(commit: RevCommit) {
             textView.textSize = 16f
-            textView.text = commit.authorIdent.name + " - " + commit.shortMessage
+            textView.text = "${commit.authorIdent.name}-${commit.shortMessage}"
         }
     }
 }

app/src/main/res/drawable/round_insert_drive_file_24.xml

@@ -46,7 +46,7 @@
             android:id="@+id/button"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="Install"
+            android:text="@string/install"
             app:layout_constraintStart_toEndOf="@id/name"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintTop_toTopOf="parent"

app/src/main/res/layout/new_plugin_item.xml

@@ -11,7 +11,7 @@
     <item
         android:id="@+id/clear"
         android:icon="@drawable/baseline_close_24"
-        android:title="Clear"
+        android:title="@string/clear"
         app:showAsAction="always" />
 
     <item

app/src/main/res/menu/chat_menu.xml

@@ -6,12 +6,13 @@
   -->
 
 <menu xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     xmlns:app="http://schemas.android.com/apk/res-auto">
 
     <item
         android:id="@+id/nav_items"
         android:icon="@drawable/nav_icon"
-        android:title="Navigation Elements"
+        android:title="@string/navigation_elements"
         app:showAsAction="always" />
 
     <item
@@ -30,7 +31,8 @@
         android:id="@+id/redo"
         android:icon="@drawable/baseline_redo_24"
         android:title="@string/redo"
-        app:showAsAction="always" />
+        app:showAsAction="always"
+        tools:ignore="AlwaysShowAction" />
 
 
     <item
@@ -40,7 +42,7 @@
 
     <item
         android:id="@+id/action_format"
-        android:title="Format"
+        android:title="@string/format"
         app:showAsAction="never" />
 
     <item
@@ -53,6 +55,6 @@
 
     <item
         android:id="@+id/action_git"
-        android:title="Git" />
+        android:title="@string/git" />
 
 </menu>

app/src/main/res/menu/menu_main.xml

@@ -9,17 +9,17 @@
 
     <item
         android:id="@+id/close_tab"
-        android:title="Close Tab" />
+        android:title="@string/close_tab" />
     <item
         android:id="@+id/close_left_tab"
-        android:title="Close Left Tab" />
+        android:title="@string/close_left_tab" />
     <item
         android:id="@+id/close_right_tab"
-        android:title="Close Right Tab" />
+        android:title="@string/close_right_tab" />
     <item
         android:id="@+id/close_other_tab"
-        android:title="Close Other Tabs" />
+        android:title="@string/close_other_tabs" />
     <item
         android:id="@+id/close_all_tab"
-        android:title="Close All Tabs" />
+        android:title="@string/close_all_tabs" />
 </menu>