Skip to content

Commit 8090a8e

Browse files
committed
- Adjust GitVersionWrapperTests assertion to include defaultBuildRevision in version comparison.
- Mark `Dispose_FileNotExistsNoThrow_NotThrowsException` as `[Obsolete]` due to obsolete method in `System.IO.Abstractions`. - Replace unnecessary async usage in `SynchronizedValueTests` with thread-based implementation for improved test reliability.
1 parent 7d47b42 commit 8090a8e

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

tests/CreativeCoders.Core.UnitTests/IO/FileCleanUpTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ namespace CreativeCoders.Core.UnitTests.IO;
1414
public class FileCleanUpTests
1515
{
1616
[Fact]
17+
[Obsolete("Obsolete cause underlying method from System.IO.Abstractions is marked as obsolete")]
1718
public void Dispose_FileNotExistsNoThrow_NotThrowsException()
1819
{
1920
var mockFileSystem = new MockFileSystemEx(

tests/CreativeCoders.Core.UnitTests/Threading/SynchronizedValueTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void SetValue_ParallelReadValue_ValueAfterSetIsReturned()
9696
long readTimeMs = 0;
9797

9898
// Act
99-
var setTask = new Thread(async () =>
99+
var setTask = new Thread(() =>
100100
{
101101
synchronizedValue.SetValue(_ =>
102102
{

tests/CreativeCoders.MiscTest.UnitTests/NukeBuild/GitVersionWrapperTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void GetAssemblySemFileVer_GitVersionReturnsNull_ReturnsDefaultVersion(
8787
// Assert
8888
actualVersion
8989
.Should()
90-
.Be(defaultVersion);
90+
.Be(defaultVersion + $".{defaultBuildRevision}");
9191
}
9292

9393
[Theory]

0 commit comments

Comments
 (0)