refactor(homeMatic): improve test readability and update annotations

- Replaced `Encoding.UTF8.GetBytes` with `u8.ToArray` for concise byte array creation in tests.
- Updated `BackupCcuOptions` annotation from `[UsedImplicitly]` to `[PublicAPI]` for better tooling support.
- Simplified `SingleHandlerHttpClientFactory` by converting to a C# primary constructor.
- Refactored conditional logic in `QueueingHttpMessageHandler` for cleaner exception handling.

Author: darthsharp

source/Tools/Cli/CreativeCoders.HomeMatic.Tools.Cli.Commands/Ccu/Backup/BackupCcuOptions.cs

@@ -3,7 +3,7 @@
 
 namespace CreativeCoders.HomeMatic.Tools.Cli.Commands.Ccu.Backup;
 
-[UsedImplicitly]
+[PublicAPI]
 public class BackupCcuOptions
 {
     [OptionValue(0, IsRequired = true, HelpText = "Name of the configured CCU connection")]

tests/CreativeCoders.HomeMatic.Tests/FirmwareBackup/FirmwareBackupClientFactoryIntegrationTests.cs

@@ -11,7 +11,7 @@ namespace CreativeCoders.HomeMatic.Tests.FirmwareBackup;
 public class FirmwareBackupClientFactoryIntegrationTests
 {
     private const string FakeSessionId = "session-id-xyz";
-    private static readonly byte[] BackupPayload = Encoding.UTF8.GetBytes("BACKUP-CONTENT");
+    private static readonly byte[] BackupPayload = "BACKUP-CONTENT"u8.ToArray();
 
     [Fact]
     public async Task CreateBackupAsync_HappyPath_PerformsLoginDownloadAndLogout()
@@ -42,7 +42,8 @@ public async Task CreateBackupAsync_HappyPath_PerformsLoginDownloadAndLogout()
         handler.Requests[0].Body.Should().Contain("\"Session.login\"").And.Contain("\"Admin\"");
         handler.Requests[1].Uri.AbsolutePath.Should().Be("/config/cp_security.cgi");
         handler.Requests[1].Method.Should().Be(HttpMethod.Get);
-        handler.Requests[1].Uri.Query.Should().Contain($"sid=%40{FakeSessionId}%40").And.Contain("action=create_backup");
+        handler.Requests[1].Uri.Query.Should().Contain($"sid=%40{FakeSessionId}%40").And
+            .Contain("action=create_backup");
     }
 
     [Fact]

tests/CreativeCoders.HomeMatic.Tests/FirmwareBackup/QueueingHttpMessageHandler.cs

@@ -52,12 +52,9 @@ protected override async Task<HttpResponseMessage> SendAsync(
 
         Requests.Add(new RecordedRequest(request.Method, request.RequestUri!, body));
 
-        if (_responders.Count == 0)
-        {
-            throw new InvalidOperationException("No more responses queued.");
-        }
-
-        return _responders.Dequeue()(request);
+        return _responders.Count == 0
+            ? throw new InvalidOperationException("No more responses queued.")
+            : _responders.Dequeue()(request);
     }
 }
 

tests/CreativeCoders.HomeMatic.Tests/FirmwareBackup/SingleHandlerHttpClientFactory.cs

@@ -4,17 +4,10 @@ namespace CreativeCoders.HomeMatic.Tests.FirmwareBackup;
 /// Minimal <see cref="IHttpClientFactory"/> that returns a single <see cref="HttpClient"/> backed by
 /// the given <see cref="HttpMessageHandler"/>.
 /// </summary>
-internal sealed class SingleHandlerHttpClientFactory : IHttpClientFactory
+internal sealed class SingleHandlerHttpClientFactory(HttpMessageHandler handler) : IHttpClientFactory
 {
-    private readonly HttpMessageHandler _handler;
-
-    public SingleHandlerHttpClientFactory(HttpMessageHandler handler)
-    {
-        _handler = handler;
-    }
-
     public HttpClient CreateClient(string name)
     {
-        return new HttpClient(_handler, disposeHandler: false);
+        return new HttpClient(handler, disposeHandler: false);
     }
 }