Update name limit

Author: benjaminjb

pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go

@@ -546,11 +546,10 @@ type AdditionalVolume struct {
 	// Volumes are mounted in the pods at `volumes/<NAME>`
 	// Must be unique.
 	// ---
-	// The `Name` field is a `DNS1123Subdomain` type to enforce
-	// the max length and also allow us to more easily transition
-	// to CPK-provisioned volumes.
+	// The `Name` field is a `DNS1123Label` type to enforce
+	// the max length.
 	// +required
-	Name DNS1123Subdomain `json:"name"`
+	Name DNS1123Label `json:"name"`
 
 	// A reference to a preexisting PVC.
 	// ---

pkg/apis/postgres-operator.crunchydata.com/v1beta1/shared_types.go

@@ -32,6 +32,16 @@ type ConfigDataKey = string
 // +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?([.][a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`
 type DNS1123Subdomain = string
 
+// ---
+// https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation#IsDNS1123Label
+// https://pkg.go.dev/k8s.io/apiserver/pkg/cel/library#Format
+//
+// +kubebuilder:validation:MinLength=1
+// Max length is less than max 63 to allow prepending `volumes-` to name
+// +kubebuilder:validation:MaxLength=55
+// +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?$`
+type DNS1123Label = string
+
 // ---
 // Duration represents a string accepted by the Kubernetes API in the "duration"
 // [format]. This format extends the "duration" [defined by OpenAPI] by allowing