Skip to content

Commit e89d662

Browse files
author
Robert Ramirez
committed
fix macos cmake arch var to allow overriding via command line
only generate fat if compiler supports it port back some workflow fixes add aarch64 support to info template min-api update
1 parent b9104e0 commit e89d662

File tree

5 files changed

+39
-19
lines changed

5 files changed

+39
-19
lines changed

.github/workflows/main.yml

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
name: Release
22

33
on:
4+
create:
5+
tags:
6+
- v*
47
workflow_dispatch:
58

69
jobs:
@@ -9,7 +12,7 @@ jobs:
912
strategy:
1013
matrix:
1114
os: [macos-latest, windows-latest]
12-
config: [debug, release]
15+
config: [release]
1316

1417
steps:
1518
- uses: actions/checkout@v2
@@ -24,7 +27,7 @@ jobs:
2427

2528
- name: configure_macos
2629
if: matrix.os == 'macos-latest'
27-
run: mkdir build && cd build && cmake -G Xcode ..
30+
run: mkdir build && cd build && cmake -G Xcode .. "-DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"
2831

2932
- name: configure_windows
3033
if: matrix.os == 'windows-latest'
@@ -69,6 +72,7 @@ jobs:
6972
if [ -d java-classes ]; then cp -r java-classes $PACKAGE_NAME; fi
7073
if [ -d java-doc ]; then cp -r java-doc $PACKAGE_NAME; fi
7174
if [ -d javascript ]; then cp -r javascript $PACKAGE_NAME; fi
75+
if [ -d jsextensions ]; then cp -r jsextensions $PACKAGE_NAME; fi
7276
if [ -d jsui ]; then cp -r jsui $PACKAGE_NAME; fi
7377
if [ -d media ]; then cp -r media $PACKAGE_NAME; fi
7478
if [ -d misc ]; then cp -r misc $PACKAGE_NAME; fi
@@ -101,9 +105,16 @@ jobs:
101105
release:
102106
runs-on: ubuntu-latest
103107
needs: package
104-
if: ${{ contains( github.ref, 'refs/tags/' ) }}
105108

106109
steps:
110+
- uses: actions/checkout@v2
111+
with:
112+
submodules: 'recursive'
113+
fetch-depth: '0'
114+
115+
- uses: battila7/get-version-action@v2
116+
id: get_version
117+
107118
- uses: benjlevesque/[email protected]
108119
id: short-sha
109120
with:
@@ -119,15 +130,15 @@ jobs:
119130
working-directory: ${{ github.event.repository.name }}
120131

121132
- name: zip
122-
run: zip -r ${{ github.event.repository.name }}-package-for-max-${{ steps.short-sha.outputs.sha }}.zip ${{ github.event.repository.name }}
133+
run: zip -r ${{ github.event.repository.name }}-package-for-max-${{ steps.get_version.outputs.version }}.zip ${{ github.event.repository.name }}
123134

124135
- uses: actions/upload-artifact@v2
125136
with:
126-
name: ${{ github.event.repository.name }}-${{ steps.short-sha.outputs.sha }}-zipped-release
127-
path: ${{ github.event.repository.name }}-package-for-max-${{ steps.short-sha.outputs.sha }}.zip
137+
name: ${{ github.event.repository.name }}-${{ steps.get_version.outputs.version }}-zipped-release
138+
path: ${{ github.event.repository.name }}-package-for-max-${{ steps.get_version.outputs.version }}.zip
128139

129140
- uses: ncipollo/release-action@v1
130141
with:
131-
artifacts: ${{ github.event.repository.name }}-package-for-max-${{ steps.short-sha.outputs.sha }}.zip
142+
artifacts: ${{ github.event.repository.name }}-package-for-max-${{ steps.get_version.outputs.version }}.zip
132143
body: "Max Package for all supported platforms"
133144
token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
- develop
88
pull_request:
99
branches:
10-
- master
10+
- main
1111
- develop
1212
workflow_dispatch:
1313

CMakeLists.txt

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,25 @@ enable_testing()
55

66
string(REGEX REPLACE "(.*)/" "" THIS_PACKAGE_NAME "${CMAKE_CURRENT_SOURCE_DIR}")
77

8-
set(CMAKE_OSX_ARCHITECTURES x86_64;arm64)
9-
10-
11-
if (${CMAKE_GENERATOR} MATCHES "Xcode")
12-
if (${XCODE_VERSION} VERSION_LESS 10)
13-
message(STATUS "Xcode 10 or higher is required. Please install from the Mac App Store.")
14-
return ()
15-
endif ()
16-
endif ()
8+
if (APPLE)
9+
if (${CMAKE_GENERATOR} MATCHES "Xcode")
10+
if (${XCODE_VERSION} VERSION_LESS 10)
11+
message(STATUS "Xcode 10 or higher is required. Please install from the Mac App Store.")
12+
return ()
13+
elseif(${XCODE_VERSION} VERSION_GREATER_EQUAL 12)
14+
set(C74_BUILD_FAT YES)
15+
endif ()
16+
endif ()
1717

18+
if (NOT CMAKE_OSX_ARCHITECTURES)
19+
if(C74_BUILD_FAT)
20+
set(CMAKE_OSX_ARCHITECTURES "x86_64;arm64" CACHE STRING "macOS architecture" FORCE)
21+
else()
22+
set(CMAKE_OSX_ARCHITECTURES "x86_64" CACHE STRING "macOS architecture" FORCE)
23+
endif()
24+
endif()
25+
message("CMAKE_OSX_ARCHITECTURES set to ${CMAKE_OSX_ARCHITECTURES}")
26+
endif()
1827

1928
# Fetch the correct version of the min-api
2029
message(STATUS "Updating Git Submodules")

package-info.json.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"name" : "@C74_PACKAGE_NAME@",
77
"os" : {
88
"macintosh" : {
9-
"platform" : [ "x64" ],
9+
"platform" : [ "x64", "aarch64" ],
1010
"min_version" : "none"
1111
},
1212
"windows" : {

0 commit comments

Comments
 (0)