Skip to content

Commit 2756160

Browse files
committed
fixup
1 parent 3ce928d commit 2756160

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

src/trusted/service_runtime/CMakeLists.txt

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/../../../cmake)
1010

1111
include(DaemonPlatform/Platform)
1212

13-
#FIXME: What to do with it?
13+
#FIXME: What to do with this?
1414
set(CPPPATH "${CMAKE_BINARY_DIR}/gen")
1515

1616
# normally comment out -- uncomment out to test the pedantic removal
@@ -122,9 +122,9 @@ elseif (ARCH STREQUAL "amd64")
122122

123123
#TODO: AMD64_ZERO_BASED_SANDBOX = env.Bit('x86_64_zero_based_sandbox')
124124
if (AMD64_ZERO_BASED_SANDBOX)
125-
#TODO: env.Append(CPPDEFINES=['-DNACL_X86_64_ZERO_BASED_SANDBOX=1'])
125+
#TODO: env.Append(CPPDEFINES=['-DNACL_X86_64_ZERO_BASED_SANDBOX=1'])
126126
else()
127-
#TODO: env.Append(CPPDEFINES=['-DNACL_X86_64_ZERO_BASED_SANDBOX=0'])
127+
#TODO: env.Append(CPPDEFINES=['-DNACL_X86_64_ZERO_BASED_SANDBOX=0'])
128128
endif()
129129
endif()
130130
elseif(ARCH STREQUAL "armhf")
@@ -265,9 +265,9 @@ if (LINUX)
265265
# nacl_signal.c needs to be compiled without the stack protector
266266
# on i386.
267267
# See https://code.google.com/p/nativeclient/issues/detail?id=3581.
268-
#TODO: nacl_signal_env.FilterOut(CCFLAGS=['-fstack-protector', '-fstack-protector-all'])
269-
#TODO: nacl_signal_env.Append(CCFLAGS=['-fno-stack-protector'])
270-
#TODO: NACL_SIGNAL_OBJ = nacl_signal_env.ComponentObject('linux/nacl_signal.c')])
268+
#TODO: nacl_signal_env.FilterOut(CCFLAGS=['-fstack-protector', '-fstack-protector-all'])
269+
#TODO: nacl_signal_env.Append(CCFLAGS=['-fno-stack-protector'])
270+
#TODO: NACL_SIGNAL_OBJ = nacl_signal_env.ComponentObject('linux/nacl_signal.c')])
271271
set(LDR_INPUTS ${LDR_INPUTS} ${NACL_SIGNAL_OBJ})
272272
endif()
273273
endif()
@@ -327,10 +327,10 @@ if (WIN32)
327327
kernel32
328328
advapi32
329329
winmm
330-
# TODO(gregoryd): ntdll.lib is required for sem_get_value implementation but
331-
# it is available in Windows DDK only. The DDK is not
332-
# in third_party, but we might need to add it if we want to use it.
333-
# ntdll
330+
# TODO(gregoryd): ntdll.lib is required for sem_get_value implementation but
331+
# it is available in Windows DDK only. The DDK is not
332+
# in third_party, but we might need to add it if we want to use it.
333+
# ntdll
334334
)
335335
endif()
336336

@@ -413,7 +413,7 @@ if (LINUX AND NOT BUILD_ELSEWHERE)
413413

414414
set(COMPILER_OVERRIDE '')
415415

416-
if (SYSTEM_amd64)
416+
if (ARCH STREQUAL "amd64")
417417
set(LD_EMUL 'elf_x86_64')
418418

419419
#TODO: AMD64_ZERO_BASED_SANDBOX = env.Bit('x86_64_zero_based_sandbox')
@@ -445,16 +445,16 @@ if (LINUX AND NOT BUILD_ELSEWHERE)
445445
else()
446446
set(reserve_top '0x0')
447447
endif()
448-
elseif (SYSTEM_i686)
448+
elseif (ARCH STREQUAL "i686")
449449
set(LD_EMUL 'elf_i386')
450450
set(RESERVE_TOP '0x40000000')
451-
elseif (SYSTEM_armhf)
452-
set(ld_emul 'armelf_linux_eabi')
453-
set(reserve_top '0x40002000')
454-
set(compiler_override '--compiler arm-linux-gnueabihf-gcc')
455-
elseif (SYSTEM_mips32)
456-
set(ld_emul 'elf32ltsmip')
457-
set(reserve_top '0x40008000')
451+
elseif (ARCH STREQUAL "armhf")
452+
set(LD_EMUL 'armelf_linux_eabi')
453+
set(RESERVE_TOP '0x40002000')
454+
set(COMPILER_OVERRIDE '--compiler arm-linux-gnueabihf-gcc')
455+
elseif (ARCH STREQUAL "mips32")
456+
set(LD_EMOUL 'elf32ltsmip')
457+
set(RESERVE_TOP '0x40008000')
458458
endif()
459459

460460
#TODO: bootstrap_obj = bootstrap_env.ComponentObject('linux/nacl_bootstrap.c')

0 commit comments

Comments
 (0)