-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Upgrade eslint-config-prettier from 8.3.0 to 10.1.8 #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade eslint-config-prettier from 8.3.0 to 10.1.8. See this package in npm: eslint-config-prettier See this project in Snyk: https://app.snyk.io/org/dargon789/project/2c91b4d5-8055-4239-a4a4-26da9ab76b7c?utm_source=github&utm_medium=referral&page=upgrade-pr
Deployment failed with the following error:
Learn More: https://vercel.com/dargon789s-projects?upgradeToPro=build-rate-limit |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, automatically generated by Snyk, updates a core development dependency to ensure the project remains secure and uses the latest features. It's crucial to verify compatibility due to the substantial version jump and potential breaking changes introduced in the new major versions.
Highlights
- Dependency Upgrade: Upgraded the
eslint-config-prettier
dependency from version8.3.0
to10.1.8
. This is a significant major version jump, spanning 22 versions. - Potential Breaking Changes: This upgrade involves major versions and may introduce breaking changes. Review of the
eslint-config-prettier
release notes is recommended to understand the impact, especially regarding the new/flat
entry for ESLint flat config users and migration to exports field.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR upgrades eslint-config-prettier
. While the change itself is correct for compatibility with ESLint v9, I've identified critical incompatibilities with other ESLint-related packages in your devDependencies
. Specifically, @typescript-eslint/parser
and eslint-plugin-prettier
appear to be outdated for your ESLint version and will likely break your linting process. I've detailed these issues and provided recommendations in a single comment on the package.json
file.
"chai": "^5.2.0", | ||
"eslint": "^9.28.0", | ||
"eslint-config-prettier": "8.3.0", | ||
"eslint-config-prettier": "10.1.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR correctly updates eslint-config-prettier
, I've noticed several other ESLint-related dependencies in this package.json
that appear to be incompatible, which will likely cause your lint
script to fail. This is a major version upgrade and it's important to check the ecosystem compatibility.
Here are the issues I've found:
-
@typescript-eslint/parser
(critical): Version5.61.0
(line 52) is not compatible witheslint@^9.28.0
(line 54). For ESLint v9, you need@typescript-eslint/parser
version 8.x or newer. I recommend upgrading this package to a version that matches the major version of@typescript-eslint/eslint-plugin
(which appears to be v8). -
eslint-plugin-prettier
(high): Version3.4.0
(line 58) is also very likely incompatible with ESLint v9. The recommended practice with ESLint v9 is to run Prettier as a separate tool, which yourlint
script already does. Therefore,eslint-plugin-prettier
is redundant and should probably be removed to avoid conflicts.
Addressing these incompatibilities is crucial for your linting setup to work correctly after this upgrade.
Snyk has created this PR to upgrade eslint-config-prettier from 8.3.0 to 10.1.8.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 22 versions ahead of your current version.
The recommended version was released 2 months ago.
Release notes
Package name: eslint-config-prettier
republish latest version
Full Changelog: v10.1.5...v10.1.8
Patch Changes
60fef02
Thanks @ JounQin! - chore: addfunding
field intopackage.json
Full Changelog: v10.1.4...v10.1.5
Patch Changes
94b4799
Thanks @ silvenon! - fix(cli): do not crash on no rules configuredFull Changelog: v10.1.3...v10.1.4
Patch Changes
4e95a1d
Thanks @ pilikan! - fix: this package iscommonjs
, align its types correctlyNew Contributors
Full Changelog: v10.1.2...v10.1.3
Patch Changes
a8768bf
Thanks @ Fdawgs! - chore(package): add homepage for some 3rd-party registry - see #321 for more detailsPatch Changes
#309
eb56a5e
Thanks @ JounQin! - fix: separate the/flat
entry for compatibilityFor flat config users, the previous
"eslint-config-prettier"
entry still works, but"eslint-config-prettier/flat"
adds a newname
property for config-inspector, we just can't add it for the default entry for compatibility.See also #308
import eslintConfigPrettier from "eslint-config-prettier";
// after
import eslintConfigPrettier from "eslint-config-prettier/flat";
Minor Changes
56e2e34
Thanks @ JounQin! - feat: migrate to exports fieldPatch Changes
#294
8dbbd6d
Thanks @ FloEdelmann! - feat: add name to config#280
cba5737
Thanks @ zanminkian! - feat: add declaration fileNew Contributors
Full Changelog: v10.0.2...v10.0.3
Patch Changes
e750edc
Thanks @ Fdawgs! - chore(package): explicitly declare js module typeeslint-config-prettier
10.0.1
What's Changed
@ stylistic/eslint-plugin
by @ abrahamguo in #272New Contributors
Full Changelog: v9.1.0...v10.0.1
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: