-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Upgrade eslint-plugin-import from 2.27.5 to 2.32.0 #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade eslint-plugin-import from 2.27.5 to 2.32.0. See this package in npm: eslint-plugin-import See this project in Snyk: https://app.snyk.io/org/dargon789/project/2c91b4d5-8055-4239-a4a4-26da9ab76b7c?utm_source=github&utm_medium=referral&page=upgrade-pr
Deployment failed with the following error:
Learn More: https://vercel.com/dargon789s-projects?upgradeToPro=build-rate-limit |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request automates the upgrade of the eslint-plugin-import
dependency to its latest stable version. This update ensures the project benefits from the newest linting rules, bug fixes, and performance enhancements, contributing to a more robust and maintainable codebase.
Highlights
- Dependency Upgrade: Upgraded the
eslint-plugin-import
dependency from version2.27.5
to2.32.0
. - New Features and Enhancements: Introduces a new
enforce-node-protocol-usage
rule, adds TypeScript types, and enhances existing rules likeextensions
andorder
with new options for improved import management and sorting. - ESLint v9 and Flat Config Support: Includes support for ESLint v9 and the new Flat Config format, improving compatibility with modern ESLint setups.
- Bug Fixes and Performance Improvements: Addresses several bug fixes across various rules (e.g.,
no-unused-modules
,no-named-as-default
,export
) and includes performance optimizations for rules likeno-cycle
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades eslint-plugin-import
for the hardhat-truffle5
package. While this is a beneficial update, I've identified an inconsistency. The same dependency exists in the hardhat-web3
package but is not being updated, which could lead to issues. My review comment provides details on this and recommends updating the dependency across all relevant packages in the monorepo for consistency.
"eslint": "^9.28.0", | ||
"eslint-config-prettier": "8.3.0", | ||
"eslint-plugin-import": "2.27.5", | ||
"eslint-plugin-import": "2.32.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating this dependency is a good step, I've noticed that another package in this monorepo, hardhat-web3
, also depends on eslint-plugin-import
but is not being updated in this PR (it remains on version 2.27.5
in packages/hardhat-web3/package.json
). To maintain consistency and avoid potential issues arising from different versions of the same dependency within the project, it would be best to update it in all packages simultaneously.
Snyk has created this PR to upgrade eslint-plugin-import from 2.27.5 to 2.32.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 7 versions ahead of your current version.
The recommended version was released 3 months ago.
Release notes
Package name: eslint-plugin-import
Added
enforce-node-protocol-usage
rule andimport/node-version
setting (#3024, thanks @ GoldStrikeArch and @ sevenc-nanashi)extensions
: add `pathGroupOverrides to allow enforcement decision overrides based on specifier (#3105, thanks @ Xunnamius)order
: addsortTypesGroup
option to allow intragroup sorting of type-only imports (#3104, thanks @ Xunnamius)order
: addnewlines-between-types
option to control intragroup sorting of type-only imports (#3127, thanks @ Xunnamius)order
: addconsolidateIslands
option to collapse excess spacing for aesthetically pleasing imports (#3129, thanks @ Xunnamius)Fixed
no-unused-modules
: provide more meaningful error message when no .eslintrc is present (#3116, thanks @ michaelfaith)order
: ensure arcane imports do not cause undefined behavior (#3128, thanks @ Xunnamius)order
: resolve undefined property access issue when usingnamed
ordering (#3166, thanks @ Xunnamius)enforce-node-protocol-usage
: avoid a crash with some TS code (#3173, thanks @ ljharb)order
: codify invariants from docs into config schema (#3152, thanks @ Xunnamius)Changed
extensions
,order
: improve documentation (#3106, thanks @ Xunnamius)tseslint.config()
(#3125, thanks @ lnuvy)order
: remove unnecessary negative check (#3167, thanks @ JounQin)no-unused-modules
: add missing double quote (#3191, thanks @ albertpastrana)no-restricted-paths
: clarify wording and fix errors (#3172, thanks @ greim)Added
order
: allow validating named imports (#3043, thanks @ manuth)extensions
: add thecheckTypeImports
option (#2817, thanks @ phryneas)Fixed
ExportMap
/ flat config: includelanguageOptions
in context (#3052, thanks @ michaelfaith)no-named-as-default
: Allow using an identifier if the export is both a named and a default export (#3032, thanks @ akwodkiewicz)export
: False positive for exported overloaded functions in TS (#3065, thanks @ liuxingbaoyu)exportMap
: export map cache is tainted by unreliable parse results (#3062, thanks @ michaelfaith)exportMap
: improve cacheKey when using flat config (#3072, thanks @ michaelfaith)Changed
no-relative-packages
: fix typo (#3066, thanks @ joshuaobrien)no-cycle
: dont scc for each linted file (#3068, thanks @ soryy708)no-cycle
: adddisableScc
to docs (#3070, thanks @ soryy708)RuleTester
(#3071, thanks @ G-Rath)no-restricted-paths
: fix grammar (#3073, thanks @ unbeauvoyage)no-default-export
,no-named-export
: add test case (thanks @ G-Rath)Added
dynamic-import-chunkname
: addallowEmpty
option to allow empty leading comments (#2942, thanks [@ JiangWeixian])dynamic-import-chunkname
: Allow empty chunk name when webpackMode: 'eager' is set; add suggestions to remove name in eager mode (#3004, thanks @ amsardesai)no-unused-modules
: AddignoreUnusedTypeExports
option (#3011, thanks @ silverwind)Fixed
no-extraneous-dependencies
: allow wrong path (#3012, thanks @ chabb)no-cycle
: use scc algorithm to optimize (#2998, thanks @ soryy708)no-duplicates
: Removing duplicates breaks in TypeScript (#3033, thanks @ yesl-kim)newline-after-import
: fix considerComments option when require (#2952, thanks @ developer-bandi)order
: do not compare first path segment for relative paths (#2682) (#2885, thanks @ mihkeleidast)Changed
no-extraneous-dependencies
: Make glob pattern description more explicit (#2944, thanks @ mulztob)no-unused-modules
: add console message to help debug #2866ExportMap
: make procedures static instead of monkeypatching exportmap (#2982, thanks @ soryy708)ExportMap
: separate ExportMap instance from its builder logic (#2985, thanks @ soryy708)order
: Add a quick note on how unbound imports and --fix (#2640, thanks @ minervabot)exportMapBuilder
: avoid hoisting (#2989, thanks @ soryy708)ExportMap
: extract "builder" logic to separate files (#2991, thanks @ soryy708)order
: update the description of thepathGroupsExcludedImportTypes
option (#3036, thanks @ liby)Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: