Skip to content

Commit 0161979

Browse files
authored
[CONTP-1895] Remove ExtendedDaemonSet runtime support (#3387)
* Remove ExtendedDaemonSet runtime support Stop creating, watching, and migrating ExtendedDaemonSets. Remove the EDS flags, rollout settings, status handling, RBAC, dependency, and tests so node Agents reconcile only native DaemonSets.\n\nCONTP-1895 * Update Agent e2e dependencies Pin the e2e framework and fake intake modules to the Agent commit that enables development Helm charts for operator deployments. Signed-off-by: Timothée Bavelier <timothee.bavelier@datadoghq.com> --------- Signed-off-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>
1 parent 65a53da commit 0161979

52 files changed

Lines changed: 430 additions & 2185 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

LICENSE-3rdparty.csv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ core,github.com/DataDog/datadog-operator/api/datadoghq/common,Unknown
2424
core,github.com/DataDog/datadog-operator/api/datadoghq/v1alpha1,Unknown
2525
core,github.com/DataDog/datadog-operator/api/datadoghq/v2alpha1,Unknown
2626
core,github.com/DataDog/datadog-operator/api/utils,Unknown
27-
core,github.com/DataDog/extendeddaemonset/api/v1alpha1,Apache-2.0
2827
core,github.com/DataDog/go-libddwaf/v3,Apache-2.0
2928
core,github.com/DataDog/go-sqllexer,MIT
3029
core,github.com/DataDog/go-tuf,BSD-3-Clause

cmd/main.go

Lines changed: 22 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"sync/atomic"
1818
"time"
1919

20-
edsdatadoghqv1alpha1 "github.com/DataDog/extendeddaemonset/api/v1alpha1"
2120
"github.com/go-logr/logr"
2221
"go.uber.org/zap"
2322
"go.uber.org/zap/zapcore"
@@ -85,7 +84,6 @@ func init() {
8584
utilruntime.Must(apiregistrationv1.AddToScheme(scheme))
8685

8786
utilruntime.Must(datadoghqv1alpha1.AddToScheme(scheme))
88-
utilruntime.Must(edsdatadoghqv1alpha1.AddToScheme(scheme))
8987
utilruntime.Must(datadoghqv2alpha1.AddToScheme(scheme))
9088
utilruntime.Must(apiextensionsv1.AddToScheme(scheme))
9189
utilruntime.Must(storagev1.AddToScheme(scheme))
@@ -104,16 +102,6 @@ func (ss *stringSlice) Set(value string) error {
104102
return nil
105103
}
106104

107-
const (
108-
// ExtendedDaemonset default configuration values from https://github.com/DataDog/extendeddaemonset/blob/main/api/v1alpha1/extendeddaemonset_default.go
109-
defaultCanaryAutoPauseEnabled = true
110-
defaultCanaryAutoFailEnabled = true
111-
// default to 0, to use default value from EDS.
112-
defaultCanaryAutoPauseMaxRestarts = 0
113-
defaultCanaryAutoFailMaxRestarts = 0
114-
defaultCanaryAutoPauseMaxSlowStartDuration = 0
115-
)
116-
117105
type options struct {
118106
// Observability options
119107
metricsAddr string
@@ -129,39 +117,28 @@ type options struct {
129117
leaderElectionLeaseDuration time.Duration
130118

131119
// Controllers options
132-
supportExtendedDaemonset bool
133-
edsMaxPodUnavailable string
134-
edsMaxPodSchedulerFailure string
135-
edsCanaryDuration time.Duration
136-
edsCanaryReplicas string
137-
edsCanaryAutoPauseEnabled bool
138-
edsCanaryAutoPauseMaxRestarts int
139-
edsCanaryAutoFailEnabled bool
140-
edsCanaryAutoFailMaxRestarts int
141-
edsCanaryAutoPauseMaxSlowStartDuration time.Duration
142-
edsSlowStartAdditiveIncrease string
143-
supportCilium bool
144-
datadogAgentEnabled bool
145-
createControllerRevisions bool
146-
datadogMonitorEnabled bool
147-
datadogMonitorMaxWorkers int
148-
datadogMonitorRequeuePeriod time.Duration
149-
datadogSLOEnabled bool
150-
operatorMetricsEnabled bool
151-
maximumGoroutines int
152-
introspectionEnabled bool
153-
datadogAgentProfileEnabled bool
154-
remoteConfigEnabled bool
155-
remoteUpdatesEnabled bool
156-
managedAgentInstallationEnabled bool
157-
datadogDashboardEnabled bool
158-
datadogGenericResourceEnabled bool
159-
datadogGenericResourceMaxWorkers int
160-
datadogGenericResourceRequeuePeriod time.Duration
161-
datadogCSIDriverEnabled bool
162-
untaintControllerEnabled bool
163-
untaintControllerWaitForCSIDriver bool
164-
rolloutOnConfigMapChangeEnabled bool
120+
supportCilium bool
121+
datadogAgentEnabled bool
122+
createControllerRevisions bool
123+
datadogMonitorEnabled bool
124+
datadogMonitorMaxWorkers int
125+
datadogMonitorRequeuePeriod time.Duration
126+
datadogSLOEnabled bool
127+
operatorMetricsEnabled bool
128+
maximumGoroutines int
129+
introspectionEnabled bool
130+
datadogAgentProfileEnabled bool
131+
remoteConfigEnabled bool
132+
remoteUpdatesEnabled bool
133+
managedAgentInstallationEnabled bool
134+
datadogDashboardEnabled bool
135+
datadogGenericResourceEnabled bool
136+
datadogGenericResourceMaxWorkers int
137+
datadogGenericResourceRequeuePeriod time.Duration
138+
datadogCSIDriverEnabled bool
139+
untaintControllerEnabled bool
140+
untaintControllerWaitForCSIDriver bool
141+
rolloutOnConfigMapChangeEnabled bool
165142

166143
// Secret Backend options
167144
secretBackendCommand string
@@ -215,19 +192,6 @@ func (opts *options) Parse() {
215192
// DatadogAgentInternal
216193
flag.BoolVar(&opts.createControllerRevisions, "createControllerRevisions", false, "Enable creation of ControllerRevision snapshots on each DDA spec change")
217194

218-
// ExtendedDaemonset configuration
219-
flag.BoolVar(&opts.supportExtendedDaemonset, "supportExtendedDaemonset", false, "Support usage of Datadog ExtendedDaemonset CRD.")
220-
flag.StringVar(&opts.edsMaxPodUnavailable, "edsMaxPodUnavailable", "", "ExtendedDaemonset number of max unavailable pods during the rolling update")
221-
flag.StringVar(&opts.edsSlowStartAdditiveIncrease, "edsSlowStartAdditiveIncrease", "", "ExtendedDaemonset slow start additive increase")
222-
flag.StringVar(&opts.edsMaxPodSchedulerFailure, "edsMaxPodSchedulerFailure", "", "ExtendedDaemonset number of max pod scheduler failures")
223-
flag.DurationVar(&opts.edsCanaryDuration, "edsCanaryDuration", 10*time.Minute, "ExtendedDaemonset canary duration")
224-
flag.StringVar(&opts.edsCanaryReplicas, "edsCanaryReplicas", "", "ExtendedDaemonset number of canary pods")
225-
flag.BoolVar(&opts.edsCanaryAutoPauseEnabled, "edsCanaryAutoPauseEnabled", defaultCanaryAutoPauseEnabled, "ExtendedDaemonset canary auto pause enabled")
226-
flag.IntVar(&opts.edsCanaryAutoPauseMaxRestarts, "edsCanaryAutoPauseMaxRestarts", defaultCanaryAutoPauseMaxRestarts, "ExtendedDaemonset canary auto pause max restart count")
227-
flag.BoolVar(&opts.edsCanaryAutoFailEnabled, "edsCanaryAutoFailEnabled", defaultCanaryAutoFailEnabled, "ExtendedDaemonset canary auto fail enabled")
228-
flag.IntVar(&opts.edsCanaryAutoFailMaxRestarts, "edsCanaryAutoFailMaxRestarts", defaultCanaryAutoFailMaxRestarts, "ExtendedDaemonset canary auto fail max restart count")
229-
flag.DurationVar(&opts.edsCanaryAutoPauseMaxSlowStartDuration, "edsCanaryAutoPauseMaxSlowStartDuration", defaultCanaryAutoPauseMaxSlowStartDuration*time.Minute, "ExtendedDaemonset canary max slow start duration")
230-
231195
// Environment variable overrides applied before flag.Parse() so that
232196
// explicit CLI flags take precedence (default < env < CLI).
233197
applyEnvOptions([]envOption{
@@ -517,19 +481,6 @@ func run(opts *options) error {
517481
}
518482

519483
options := controller.SetupOptions{
520-
SupportExtendedDaemonset: controller.ExtendedDaemonsetOptions{
521-
Enabled: opts.supportExtendedDaemonset,
522-
MaxPodUnavailable: opts.edsMaxPodUnavailable,
523-
SlowStartAdditiveIncrease: opts.edsSlowStartAdditiveIncrease,
524-
CanaryDuration: opts.edsCanaryDuration,
525-
CanaryReplicas: opts.edsCanaryReplicas,
526-
CanaryAutoPauseEnabled: opts.edsCanaryAutoPauseEnabled,
527-
CanaryAutoPauseMaxRestarts: opts.edsCanaryAutoPauseMaxRestarts,
528-
CanaryAutoFailEnabled: opts.edsCanaryAutoFailEnabled,
529-
CanaryAutoFailMaxRestarts: opts.edsCanaryAutoFailMaxRestarts,
530-
CanaryAutoPauseMaxSlowStartDuration: opts.edsCanaryAutoPauseMaxSlowStartDuration,
531-
MaxPodSchedulerFailure: opts.edsMaxPodSchedulerFailure,
532-
},
533484
SupportCilium: opts.supportCilium,
534485
CredsManager: credsManager,
535486
DatadogAgentEnabled: opts.datadogAgentEnabled,
@@ -794,7 +745,6 @@ func setupAndStartOperatorMetadataForwarder(logger logr.Logger, client client.Re
794745
// Since v1.27, DDAI is always tied to DDA — no separate flag. Kept in telemetry for metric continuity.
795746
DatadogAgentInternalEnabled: options.datadogAgentEnabled,
796747
LeaderElectionEnabled: options.enableLeaderElection,
797-
ExtendedDaemonSetEnabled: options.supportExtendedDaemonset,
798748
RemoteConfigEnabled: options.remoteConfigEnabled,
799749
RemoteUpdatesEnabled: options.remoteUpdatesEnabled,
800750
IntrospectionEnabled: options.introspectionEnabled,

config/rbac/role.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ rules:
286286
- datadogmonitors/finalizers
287287
- datadogslos
288288
- datadogslos/finalizers
289-
- extendeddaemonsets
290289
verbs:
291290
- create
292291
- delete
@@ -352,15 +351,6 @@ rules:
352351
- datadogpodautoscalers/status
353352
verbs:
354353
- '*'
355-
- apiGroups:
356-
- datadoghq.com
357-
resources:
358-
- extendeddaemonsetreplicasets
359-
verbs:
360-
- delete
361-
- get
362-
- list
363-
- watch
364354
- apiGroups:
365355
- discovery.k8s.io
366356
resources:

go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ go 1.26.7
55
require (
66
github.com/DataDog/datadog-agent/pkg/util/scrubber v0.63.0-rc.1 // indirect
77
github.com/DataDog/datadog-api-client-go/v2 v2.56.0
8-
// TODO: pin to an EDS released version once there is a release that includes the api module
9-
github.com/DataDog/extendeddaemonset/api v0.0.0-20250108205105-6c4d337b78a1
108
github.com/Masterminds/semver/v3 v3.4.0
119
github.com/go-logr/logr v1.4.3
1210
github.com/gobwas/glob v0.2.3

go.sum

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ github.com/DataDog/datadog-go/v5 v5.6.0 h1:2oCLxjF/4htd55piM75baflj/KoE6VYS7alEU
5353
github.com/DataDog/datadog-go/v5 v5.6.0/go.mod h1:K9kcYBlxkcPP8tvvjZZKs/m1edNAUFzBbdpTUKfCsuw=
5454
github.com/DataDog/datadog-operator/api v0.0.0-20250130131115-7f198adcc856 h1:zHq/clXi0DJQsZj2WD3WTqlg/WXGicNH3DjXa0ARpWk=
5555
github.com/DataDog/datadog-operator/api v0.0.0-20250130131115-7f198adcc856/go.mod h1:Ef4llzn4c4p6FPZNjeYgIQFHa2va2JPC8Wf/kivrF2E=
56-
github.com/DataDog/extendeddaemonset/api v0.0.0-20250108205105-6c4d337b78a1 h1:K9SD6kTk58j3vG99mExuVIFh994JSpPALQRr2MPszXQ=
57-
github.com/DataDog/extendeddaemonset/api v0.0.0-20250108205105-6c4d337b78a1/go.mod h1:CLkfm3awFwTY5aBDm8esFwiocXIoNxY28eK6zZ5u9t0=
5856
github.com/DataDog/go-libddwaf/v3 v3.3.0 h1:jS72fuQpFgJZEdEJDmHJCPAgNTEMZoz1EUvimPUOiJ4=
5957
github.com/DataDog/go-libddwaf/v3 v3.3.0/go.mod h1:Bz/0JkpGf689mzbUjKJeheJINqsyyhM8p9PDuHdK2Ec=
6058
github.com/DataDog/go-sqllexer v0.0.15 h1:rUUu52dP8EQhJLnUw0MIAxZp0BQx2fOTuMztr3vtHUU=

go.work.sum

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,6 @@ github.com/DataDog/datadog-agent/pkg/util/testutil v0.63.0-rc.1 h1:3Ct/38ONls2/g
324324
github.com/DataDog/datadog-agent/pkg/util/testutil v0.63.0-rc.1/go.mod h1:y1l7iTMENfjfgV4L3a5RtsMiQAVeu6B/0SEo6A8XDFQ=
325325
github.com/DataDog/datadog-api-client-go v1.16.0 h1:5jOZv1m98criCvYTa3qpW8Hzv301nbZX3K9yJtwGyWY=
326326
github.com/DataDog/datadog-api-client-go v1.16.0/go.mod h1:PgrP2ABuJWL3Auw2iEkemAJ/r72ghG4DQQmb5sgnKW4=
327-
github.com/DataDog/extendeddaemonset v0.10.0-rc.4 h1:m88E+emuRHIqKgi7kHMd9N0S/NtruCCOISp3cjB7DNs=
328327
github.com/DataDog/zstd v1.5.2/go.mod h1:g4AWEaM3yOg3HYfnJ3YIawPnVdXJh9QME85blwSAmyw=
329328
github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp v1.5.0 h1:oVLqHXhnYtUwM89y9T1fXGaK9wTkXHgNp8/ZNMQzUxE=
330329
github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp v1.5.0/go.mod h1:dppbR7CwXD4pgtV9t3wD1812RaLDcBjtblcDF5f1vI0=

internal/controller/datadogagent/component/agent/default.go

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"strconv"
1212
"strings"
1313

14-
edsv1alpha1 "github.com/DataDog/extendeddaemonset/api/v1alpha1"
1514
appsv1 "k8s.io/api/apps/v1"
1615
corev1 "k8s.io/api/core/v1"
1716
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -32,20 +31,13 @@ import (
3231

3332
// NewDefaultAgentDaemonset return a new default agent DaemonSet
3433
// TODO: remove instanceName once v2 reconcile is removed
35-
func NewDefaultAgentDaemonset(dda metav1.Object, edsOptions *ExtendedDaemonsetOptions, agentComponent feature.RequiredComponent, instanceName string) *appsv1.DaemonSet {
36-
daemonset := NewDaemonset(dda, edsOptions, constants.DefaultAgentResourceSuffix, component.GetAgentName(dda), common.GetAgentVersion(dda), nil, instanceName)
34+
func NewDefaultAgentDaemonset(dda metav1.Object, agentComponent feature.RequiredComponent, instanceName string) *appsv1.DaemonSet {
35+
daemonset := NewDaemonset(dda, constants.DefaultAgentResourceSuffix, component.GetAgentName(dda), common.GetAgentVersion(dda), nil, instanceName)
3736
podTemplate := NewDefaultAgentPodTemplateSpec(dda, agentComponent, daemonset.GetLabels())
3837
daemonset.Spec.Template = *podTemplate
3938
return daemonset
4039
}
4140

42-
// NewDefaultAgentExtendedDaemonset return a new default agent DaemonSet
43-
func NewDefaultAgentExtendedDaemonset(dda metav1.Object, edsOptions *ExtendedDaemonsetOptions, agentComponent feature.RequiredComponent) *edsv1alpha1.ExtendedDaemonSet {
44-
edsDaemonset := NewExtendedDaemonset(dda, edsOptions, constants.DefaultAgentResourceSuffix, component.GetAgentName(dda), common.GetAgentVersion(dda), nil)
45-
edsDaemonset.Spec.Template = *NewDefaultAgentPodTemplateSpec(dda, agentComponent, edsDaemonset.GetLabels())
46-
return edsDaemonset
47-
}
48-
4941
// NewDefaultAgentPodTemplateSpec returns a defaulted node agent PodTemplateSpec with a single multi-process container or multiple single-process containers
5042
func NewDefaultAgentPodTemplateSpec(dda metav1.Object, agentComponent feature.RequiredComponent, labels map[string]string) *corev1.PodTemplateSpec {
5143
requiredContainers := agentComponent.Containers

internal/controller/datadogagent/component/agent/new.go

Lines changed: 1 addition & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,14 @@
66
package agent
77

88
import (
9-
"time"
10-
11-
edsv1alpha1 "github.com/DataDog/extendeddaemonset/api/v1alpha1"
129
appsv1 "k8s.io/api/apps/v1"
1310
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1411

15-
apiutils "github.com/DataDog/datadog-operator/api/utils"
1612
"github.com/DataDog/datadog-operator/internal/controller/datadogagent/common"
1713
)
1814

1915
// NewDaemonset use to generate the skeleton of a new daemonset based on few information
20-
func NewDaemonset(owner metav1.Object, edsOptions *ExtendedDaemonsetOptions, componentKind, componentName, version string, selector *metav1.LabelSelector, instanceName string) *appsv1.DaemonSet {
16+
func NewDaemonset(owner metav1.Object, componentKind, componentName, version string, selector *metav1.LabelSelector, instanceName string) *appsv1.DaemonSet {
2117
labels, annotations, selector := common.GetDefaultMetadata(owner, componentKind, instanceName, version, selector)
2218

2319
daemonset := &appsv1.DaemonSet{
@@ -31,94 +27,5 @@ func NewDaemonset(owner metav1.Object, edsOptions *ExtendedDaemonsetOptions, com
3127
Selector: selector,
3228
},
3329
}
34-
if edsOptions != nil && edsOptions.MaxPodUnavailable != "" {
35-
daemonset.Spec.UpdateStrategy = appsv1.DaemonSetUpdateStrategy{
36-
RollingUpdate: &appsv1.RollingUpdateDaemonSet{
37-
MaxUnavailable: apiutils.NewIntOrStringPointer(edsOptions.MaxPodUnavailable),
38-
},
39-
}
40-
}
4130
return daemonset
4231
}
43-
44-
// NewExtendedDaemonset use to generate the skeleton of a new extended daemonset based on few information
45-
func NewExtendedDaemonset(owner metav1.Object, edsOptions *ExtendedDaemonsetOptions, componentKind, componentName, version string, selector *metav1.LabelSelector) *edsv1alpha1.ExtendedDaemonSet {
46-
// FIXME (@CharlyF): The EDS controller uses the Spec.Selector as a node selector to get the NodeList to rollout the agent.
47-
// Per https://github.com/DataDog/extendeddaemonset/blob/28a8e082cee9890ae6d925a7d6247a36c6f6ba5d/controllers/extendeddaemonsetreplicaset/controller.go#L344-L360
48-
// Up until v0.8.2, the Datadog Operator set the selector to nil, which circumvented this case.
49-
// Until the EDS controller uses the Affinity field to get the NodeList instead of Spec.Selector, let's keep the previous behavior.
50-
labels, annotations, _ := common.GetDefaultMetadata(owner, componentKind, componentName, version, selector)
51-
52-
daemonset := &edsv1alpha1.ExtendedDaemonSet{
53-
ObjectMeta: metav1.ObjectMeta{
54-
Name: componentName,
55-
Namespace: owner.GetNamespace(),
56-
Labels: labels,
57-
Annotations: annotations,
58-
},
59-
Spec: defaultEDSSpec(edsOptions),
60-
}
61-
62-
return daemonset
63-
}
64-
65-
// ExtendedDaemonsetOptions defines ExtendedDaemonset options
66-
type ExtendedDaemonsetOptions struct {
67-
Enabled bool
68-
69-
MaxPodUnavailable string
70-
MaxPodSchedulerFailure string
71-
SlowStartAdditiveIncrease string
72-
73-
CanaryDuration time.Duration
74-
CanaryReplicas string
75-
CanaryAutoPauseEnabled bool
76-
CanaryAutoPauseMaxRestarts int32
77-
CanaryAutoFailEnabled bool
78-
CanaryAutoFailMaxRestarts int32
79-
CanaryAutoPauseMaxSlowStartDuration time.Duration
80-
}
81-
82-
func defaultEDSSpec(options *ExtendedDaemonsetOptions) edsv1alpha1.ExtendedDaemonSetSpec {
83-
spec := edsv1alpha1.ExtendedDaemonSetSpec{
84-
Strategy: edsv1alpha1.ExtendedDaemonSetSpecStrategy{
85-
Canary: &edsv1alpha1.ExtendedDaemonSetSpecStrategyCanary{},
86-
},
87-
}
88-
edsv1alpha1.DefaultExtendedDaemonSetSpec(&spec, edsv1alpha1.ExtendedDaemonSetSpecStrategyCanaryValidationModeAuto)
89-
90-
if options.MaxPodUnavailable != "" {
91-
spec.Strategy.RollingUpdate.MaxUnavailable = apiutils.NewIntOrStringPointer(options.MaxPodUnavailable)
92-
}
93-
94-
if options.MaxPodSchedulerFailure != "" {
95-
spec.Strategy.RollingUpdate.MaxPodSchedulerFailure = apiutils.NewIntOrStringPointer(options.MaxPodSchedulerFailure)
96-
}
97-
98-
if options.SlowStartAdditiveIncrease != "" {
99-
spec.Strategy.RollingUpdate.SlowStartAdditiveIncrease = apiutils.NewIntOrStringPointer(options.SlowStartAdditiveIncrease)
100-
}
101-
102-
if options.CanaryDuration != 0 {
103-
spec.Strategy.Canary.Duration = &metav1.Duration{Duration: options.CanaryDuration}
104-
}
105-
106-
if options.CanaryReplicas != "" {
107-
spec.Strategy.Canary.Replicas = apiutils.NewIntOrStringPointer(options.CanaryReplicas)
108-
}
109-
110-
spec.Strategy.Canary.AutoFail.Enabled = new(options.CanaryAutoFailEnabled)
111-
if options.CanaryAutoFailMaxRestarts > 0 {
112-
spec.Strategy.Canary.AutoFail.MaxRestarts = new(options.CanaryAutoFailMaxRestarts)
113-
}
114-
115-
if options.CanaryAutoPauseMaxSlowStartDuration != 0 {
116-
spec.Strategy.Canary.AutoPause.MaxSlowStartDuration = &metav1.Duration{Duration: options.CanaryAutoPauseMaxSlowStartDuration}
117-
}
118-
119-
spec.Strategy.Canary.AutoPause.Enabled = new(options.CanaryAutoPauseEnabled)
120-
if options.CanaryAutoPauseMaxRestarts > 0 {
121-
spec.Strategy.Canary.AutoPause.MaxRestarts = new(options.CanaryAutoPauseMaxRestarts)
122-
}
123-
return spec
124-
}

internal/controller/datadogagent/component/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func GetAgentName(dda metav1.Object) string {
2222
return fmt.Sprintf("%s-%s", dda.GetName(), constants.DefaultAgentResourceSuffix)
2323
}
2424

25-
// GetDaemonSetNameFromDatadogAgent returns the expected node Agent DS/EDS name based on
25+
// GetDaemonSetNameFromDatadogAgent returns the expected node Agent DaemonSet name based on
2626
// the DDA name and nodeAgent name override
2727
func GetDaemonSetNameFromDatadogAgent(ddaObject metav1.Object, ddaSpec *v2alpha1.DatadogAgentSpec) string {
2828
dsName := GetAgentName(ddaObject)

internal/controller/datadogagent/controller.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"sigs.k8s.io/controller-runtime/pkg/reconcile"
1818

1919
"github.com/DataDog/datadog-operator/api/datadoghq/v2alpha1"
20-
componentagent "github.com/DataDog/datadog-operator/internal/controller/datadogagent/component/agent"
2120
"github.com/DataDog/datadog-operator/pkg/controller/utils/datadog"
2221
"github.com/DataDog/datadog-operator/pkg/kubernetes"
2322

@@ -90,7 +89,6 @@ type ProviderReader interface {
9089

9190
// ReconcilerOptions provides options read from command line
9291
type ReconcilerOptions struct {
93-
ExtendedDaemonsetOptions componentagent.ExtendedDaemonsetOptions
9492
SupportCilium bool
9593
OperatorMetricsEnabled bool
9694
IntrospectionEnabled bool

0 commit comments

Comments
 (0)