add slo corrections support - #3414
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 195d415ed5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: f1a5042 | Docs | View more details | Give us feedback! |
195d415 to
f1a5042
Compare
What does this PR do?
add slo corrections support
Motivation
https://datadoghq.atlassian.net/browse/CONTP-2020
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
DD_GENERIC_RESOURCE_CONTROLLER_ENABLED=trueandDD_API_KEYandDD_APP_KEYsetSYNC STATUS: OKand for ID to be populated. Check your SLO in app for the SLO correction to be created under the Corrections tabDatadogGenericResource manifest has changedandUpdated DatadogGenericResourcelogs. In app, the Correction Type should now be DeploymentChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel