feat(env): Migrate agent bootstrap to environment component

Author: PerfectSlayer

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Library.java

@@ -1,5 +1,6 @@
 package datadog.trace.bootstrap;
 
+import datadog.environment.EnvironmentVariables;
 import java.util.EnumSet;
 import org.slf4j.Logger;
 
@@ -15,7 +16,7 @@ public enum Library {
   public static EnumSet<Library> detectLibraries(final Logger log) {
     final EnumSet<Library> libraries = EnumSet.noneOf(Library.class);
 
-    final String jbossHome = System.getenv("JBOSS_HOME");
+    final String jbossHome = EnvironmentVariables.get("JBOSS_HOME");
     if (jbossHome != null) {
       log.debug("Env - jboss: {}", jbossHome);
       libraries.add(WILDFLY);

dd-java-agent/agent-logging/src/main/java/datadog/trace/logging/ddlogger/DDLoggerFactory.java

@@ -1,5 +1,7 @@
 package datadog.trace.logging.ddlogger;
 
+import datadog.environment.EnvironmentVariables;
+import datadog.environment.SystemProperties;
 import datadog.trace.api.Platform;
 import datadog.trace.logging.LogLevel;
 import datadog.trace.logging.LogLevelSwitcher;
@@ -99,14 +101,14 @@ && isFlagEnabled(
 
   private static boolean isFlagEnabled(
       final String systemProperty, final String envVar, final boolean defaultValue) {
-    String value = System.getProperty(systemProperty);
+    String value = SystemProperties.get(systemProperty);
     if ("true".equalsIgnoreCase(value)) {
       return true;
     }
     if ("false".equalsIgnoreCase(value)) {
       return false;
     }
-    value = System.getenv(envVar);
+    value = EnvironmentVariables.get(envVar);
     if ("true".equalsIgnoreCase(value)) {
       return true;
     }

dd-java-agent/src/main/java/datadog/trace/bootstrap/AgentBootstrap.java

@@ -165,7 +165,7 @@ private static void agentmainImpl(
   static boolean getConfig(String configName) {
     switch (configName) {
       case LIB_INJECTION_ENABLED_ENV_VAR:
-        return System.getenv(LIB_INJECTION_ENABLED_ENV_VAR) != null;
+        return EnvironmentVariables.get(LIB_INJECTION_ENABLED_ENV_VAR) != null;
       case LIB_INJECTION_FORCE_SYS_PROP:
         {
           String envVarName =

dd-java-agent/src/main/java/datadog/trace/bootstrap/AgentJar.java

@@ -1,5 +1,6 @@
 package datadog.trace.bootstrap;
 
+import datadog.trace.bootstrap.environment.SystemProperties;
 import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.BufferedReader;
 import java.io.IOException;
@@ -174,7 +175,7 @@ public static String getAgentVersion() throws IOException {
   }
 
   private static void checkProfilerEnv(final String[] args) throws Exception {
-    String tmpDir = args.length == 2 ? args[1] : System.getProperty("java.io.tmpdir");
+    String tmpDir = args.length == 2 ? args[1] : SystemProperties.get("java.io.tmpdir");
 
     installAgentCLI().getMethod("checkProfilerEnv", String.class).invoke(null, tmpDir);
   }

dd-java-agent/src/main/java6/datadog/trace/bootstrap/AgentPreCheck.java

@@ -101,9 +101,12 @@ static boolean compatible(String javaVersion, String javaHome, PrintStream outpu
 
     reportIncompatibleJava(javaVersion, javaHome, agentVersion, output);
 
-    String forwarderPath = System.getenv("DD_TELEMETRY_FORWARDER_PATH");
-    if (forwarderPath != null) {
-      sendTelemetry(forwarderPath, javaVersion, agentVersion);
+    try {
+      String forwarderPath = System.getenv("DD_TELEMETRY_FORWARDER_PATH");
+      if (forwarderPath != null) {
+        sendTelemetry(forwarderPath, javaVersion, agentVersion);
+      }
+    } catch (SecurityException ignored) {
     }
 
     return false;

dd-java-agent/src/test/groovy/datadog/trace/agent/InitializationTelemetryTest.groovy

@@ -55,15 +55,15 @@ class InitializationTelemetryTest extends Specification {
 
   def "incomplete agent start-up"() {
     // In this case, the SecurityManager blocks a custom permission that is checked by bytebuddy causing
-    // agent initialization to fail.  However, we should catch the exception allowing the application
+    // agent initialization to fail. However, we should catch the exception allowing the application
     // to run normally.
     when:
     def result = InitializationTelemetryCheck.runTestJvm(InitializationTelemetryCheck.BlockByteBuddy)
 
     then:
     result.exitCode == 0
     !result.telemetryJson.contains('library_entrypoint.complete')
-    result.telemetryJson.contains('error_type:java.lang.IllegalStateException')
+    result.telemetryJson.contains('error_type:java.lang.reflect.InvocationTargetException')
   }
 
   def "block forwarder env var"() {