Add support for sybase tds jdbc driver (#8764)

* Add support for sybase tds jdbc driver

* Update dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/jdbc/JDBCConnectionUrlParser.java

Co-authored-by: Raphaël Vandon <[email protected]>

* add sybase callable stmt

* Remove null check since creates sides effects

* Add sybase jdbc2 alias

---------

Co-authored-by: Raphaël Vandon <[email protected]>

Author: amarziali

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/jdbc/JDBCConnectionUrlParser.java

@@ -42,6 +42,7 @@ DBInfo.Builder doParse(final String jdbcUrl, final DBInfo.Builder builder) {
         }
 
         String path = uri.getPath();
+
         if (path.startsWith("/")) {
           path = path.substring(1);
         }
@@ -795,7 +796,23 @@ DBInfo.Builder doParse(String jdbcUrl, DBInfo.Builder builder) {
       }
       return GENERIC_URL_LIKE.doParse(url, builder);
     }
-  };
+  },
+  // https://infocenter.sybase.com/help/index.jsp?topic=/com.sybase.infocenter.dc01776.1601/doc/html/san1357754914053.html
+  // Sybase TDS
+  SYBASE_TDS("sybase") {
+    @Override
+    DBInfo.Builder doParse(String jdbcUrl, DBInfo.Builder builder) {
+      if (jdbcUrl.startsWith("sybase:tds:")) {
+        // that uri is opaque so we need to adjust it in order to be parsed with the classical
+        // hierarchical way
+        return GENERIC_URL_LIKE
+            .doParse("sybase://" + jdbcUrl.substring("sybase:tds:".length()), builder)
+            .subtype("tds");
+      }
+      return GENERIC_URL_LIKE.doParse(jdbcUrl, builder);
+    }
+  },
+  ;
 
   private static final Map<String, JDBCConnectionUrlParser> typeParsers = new HashMap<>();
 
@@ -925,6 +942,10 @@ private static void populateStandardProperties(
           ExceptionLogger.LOGGER.debug("Error parsing portnumber property: {}", portNumber, e);
         }
       }
+      if (props.containsKey("servicename")) {
+        // this property is used to specify the db to use for Sybase connection strings
+        builder.instance((String) props.get("servicename"));
+      }
 
       if (props.containsKey("portNumber")) {
         final String portNumber = (String) props.get("portNumber");

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/DefaultConnectionInstrumentation.java

@@ -45,6 +45,9 @@ public class DefaultConnectionInstrumentation extends AbstractConnectionInstrume
     "com.informix.jdbc.IfmxConnection",
     // Intersystems IRIS
     "com.intersystems.jdbc.IRISConnection",
+    // Sybase
+    "com.sybase.jdbc2.jdbc.SybConnection",
+    "com.sybase.jdbc4.jdbc.SybConnection",
     // for testing purposes
     "test.TestConnection"
   };

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/PreparedStatementInstrumentation.java

@@ -122,6 +122,11 @@ public final class PreparedStatementInstrumentation extends AbstractPreparedStat
     // Intersystems IRIS
     "com.intersystems.jdbc.IRISPreparedStatement",
     "com.intersystems.jdbc.IRISCallableStatement",
+    // sybase
+    "com.sybase.jdbc2.jdbc.SybPreparedStatement",
+    "com.sybase.jdbc2.jdbc.SybCallableStatement",
+    "com.sybase.jdbc4.jdbc.SybPreparedStatement",
+    "com.sybase.jdbc4.jdbc.SybCallableStatement",
     // for testing purposes
     "test.TestPreparedStatement"
   };

dd-java-agent/instrumentation/jdbc/src/test/groovy/JDBCConnectionUrlParserTest.groovy

@@ -204,7 +204,9 @@ class JDBCConnectionUrlParserTest extends AgentTestRunner {
     "jdbc:IRIS://dbhostname:1972/namespace"                                                                                                                                                                                                     | null     | "iris"       | null          | null          | "dbhostname"  | 1972  | null               | "namespace"
     "jdbc:IRIS://dbhostname:1972/namespace/+myjdbc.log"                                                                                                                                                                                                     | null     | "iris"       | null          | null          | "dbhostname"  | 1972  | null               | "namespace"
     "jdbc:IRIS://dbhostname:1972/namespace/::false"                                                                                                                                                                                             | null     | "iris"       | null          | null          | "dbhostname"  | 1972  | null               | "namespace"
-
+    // sybase
+    "jdbc:sybase:Tds:dbhostname:2638?ServiceName=demo"                                                                                                                                                                                          | null     | "sybase"     | "tds"         | null     | "dbhostname"                                                          | 2638    | "demo"                               | null
+    "jdbc:sybase:Tds:dbhostname:2638/dbname"                                                                                                                                                                                                    | null     | "sybase"     | "tds"         | null     | "dbhostname"                                                          | 2638    | null                                 | "dbname"
     expected = new DBInfo.Builder().type(type).subtype(subtype).user(user).instance(instance).db(db).host(host).port(port).build()
   }
 }