fix(profiling): support for greenlets [backport 3.10] #14029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
We improve the error handling around greenlet tracking to catch any unexpected errors and prevent the target application from failing to spawn greenlets. One observed case of failure was due to the string table failing to resolve a string (the greenlet name in this case) into a cache key. We expect this kind of errors to be rare, but we add logic to handle them should they occur. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Taegyun Kim <[email protected]> (cherry picked from commit 9fec84d)
P403n1x87
approved these changes
Jul 16, 2025
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 289 ± 5 ms. The average import time from base is: 286 ± 5 ms. The import time difference between this PR and base is: 2.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9fec84d from #14011 to 3.10.
We improve the error handling around greenlet tracking to catch any unexpected errors and prevent the target application from failing to spawn greenlets. One observed case of failure was due to the string table failing to resolve a string (the greenlet name in this case) into a cache key. We expect this kind of errors to be rare, but we add logic to handle them should they occur.
Checklist
Reviewer Checklist