Skip to content

Commit e4cd19c

Browse files
side-nav-main -> -js-load. make partners load async (#30571)
1 parent 9911244 commit e4cd19c

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

assets/scripts/datadog-docs.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ function getVisibleParentPath(ancestralEl, path){
153153
function hasParentLi(el) {
154154
while (el) {
155155
if (el.classList) {
156-
if (el.classList.contains('sidenav-nav-main')) {
156+
if (el.classList.contains('sidenav-nav-js-load')) {
157157
break;
158158
}
159159

@@ -174,7 +174,7 @@ function hasParentLi(el) {
174174

175175
function getPathElement(event = null) {
176176
let path = window.location.pathname;
177-
const activeMenus = document.querySelectorAll('.side .sidenav-nav-main .active, header .sidenav-nav-main .active');
177+
const activeMenus = document.querySelectorAll('.side .sidenav-nav-js-load .active, header .sidenav-nav-js-load .active');
178178

179179
// remove active class from all sidenav links to close all open menus
180180
for (let i = 0; i < activeMenus.length; i++) {
@@ -237,8 +237,8 @@ function getPathElement(event = null) {
237237

238238
// remove open class from li elements and active class from <a> elements
239239
function closeNav() {
240-
const activeMenus = document.querySelectorAll('.side .sidenav-nav-main .active, header .sidenav-nav-main .active');
241-
const openMenus = document.querySelectorAll('.side .sidenav-nav-main .open, header .sidenav-nav-main .open');
240+
const activeMenus = document.querySelectorAll('.side .sidenav-nav-js-load .active, header .sidenav-nav-js-load .active');
241+
const openMenus = document.querySelectorAll('.side .sidenav-nav-js-load .open, header .sidenav-nav-js-load .open');
242242

243243
for (let i = 0; i < activeMenus.length; i++) {
244244
activeMenus[i].classList.remove('active');
@@ -293,8 +293,8 @@ function updateSidebar(event) {
293293
}
294294
}
295295

296-
const sideNav = document.querySelector('.side .sidenav-nav-main');
297-
const mobileNav = document.querySelector('header .sidenav-nav-main');
296+
const sideNav = document.querySelector('.side .sidenav-nav-js-load');
297+
const mobileNav = document.querySelector('header .sidenav-nav-js-load');
298298

299299
if (sideNav) {
300300
sideNav.addEventListener('click', navClickEventHandler);

layouts/partials/nav/left-nav-partners.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,14 @@
5959
{{ range $menu }}
6060
<!-- check if on /partners/ top level section page, don't generate sub anchors if true -->
6161
{{ if and (.HasChildren) (ne $currentPage.CurrentSection.RelPermalink "/partners/" ) }}
62-
<li class="{{ if or ($currentPage.IsMenuCurrent $partnersMenu .) ($currentPage.HasMenuCurrent $partnersMenu .) (eq $currentEnURL .URL) }}active{{ end }}">
62+
<li class="js-load {{ if or ($currentPage.IsMenuCurrent $partnersMenu .) ($currentPage.HasMenuCurrent $partnersMenu .) (eq $currentEnURL .URL) }}active{{ end }}">
6363
{{$url_without_anchor = ((index (split .URL "#") 0) | relLangURL)}}
6464
<a href="{{ (strings.TrimLeft "/" .URL) | absLangURL }}" data-path='{{ trim (print $branchPath $url_without_anchor) "/" }}'>
6565
<span>{{ .Name }}</span>
6666
</a>
6767
<ul class="nav">
6868
{{ range .Children }}
69-
<li class="row nav-item {{ if $currentPage.IsMenuCurrent $partnersMenu . }}active{{ end }}">
69+
<li class="js-load row nav-item {{ if $currentPage.IsMenuCurrent $partnersMenu . }}active{{ end }}">
7070
{{$identifier := .Identifier}}
7171
{{/*
7272
lookup english equivalent of non-english menu item identifier attr.
@@ -86,7 +86,7 @@
8686
</ul>
8787
</li>
8888
{{ else }}
89-
<li class="{{ if or ($currentPage.IsMenuCurrent $partnersMenu .) ($currentPage.HasMenuCurrent $partnersMenu .) (eq $currentEnURL .URL) }}active{{ end }}">
89+
<li class="js-load {{ if or ($currentPage.IsMenuCurrent $partnersMenu .) ($currentPage.HasMenuCurrent $partnersMenu .) (eq $currentEnURL .URL) }}active{{ end }}">
9090
<a href="{{ (strings.TrimLeft "/" .URL) | absLangURL }}">
9191
<span>{{ .Name }}</span>
9292
</a>

layouts/partials/sidenav/main-sidenav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div id="async-searchbar-mount"></div>
1616
{{ end}}
1717

18-
<div class="sidenav-nav sidenav-nav-main">
18+
<div class="sidenav-nav sidenav-nav-js-load">
1919
{{ partialCached "nav/left-nav.html" . .Section }}
2020
</div>
2121
</div>

layouts/partials/sidenav/partners-sidenav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<div id="async-searchbar-mount"></div>
1818
{{ end}}
1919

20-
<div class="sidenav-nav">
20+
<div class="sidenav-nav sidenav-nav-js-load">
2121
{{ partial "nav/left-nav-partners.html" . }}
2222
</div>
2323
</div>

0 commit comments

Comments
 (0)