Does not compile when HDF5 2.0.0 is installed

[apavenis]

ArchLinux now has hdf5-2.0.0.
h5pp tests no more compile. Initially detected in our application, failure is also reproducible in h5pp tests

[pavenis@ap tests]$ make
[ 2%] Building CXX object CMakeFiles/h5pp-test-appendToDataset.dir/test-appendToDataset.cpp.o
In file included from /usr/local/include/h5pp/details/h5ppFile.h:10,
from /usr/local/include/h5pp/h5pp.h:2,
from /home/pavenis/GIT/ext/h5pp/tests/test-appendToDataset.cpp:3:
/usr/local/include/h5pp/details/h5ppHdf5.h: In function ‘void h5pp::hdf5::H5Dread_single_chunk(const hid_t&, const hid_t&, H5Z_filter_t&, uint32_t&, const std::vector&, std::vectorstd::byte&)’:
/usr/local/include/h5pp/details/h5ppHdf5.h:2037:59: error: too few arguments to function ‘herr_t H5Dread_chunk2(hid_t, hid_t, const hsize_t*, uint32_t*, void*, size_t*)’ [-Wtemplate-body]
2037 | herr_t err = H5Dread_chunk(h5dset, h5dxpl, chunkOffset.data(), &mask, chunkZBuffer.data());
| ^
In file included from /usr/local/include/h5pp/details/h5ppDimensionType.h:6,
from /usr/local/include/h5pp/details/h5ppFile.h:5:
/usr/include/H5Dpublic.h:1303:15: note: declared here
1303 | H5_DLL herr_t H5Dread_chunk2(hid_t dset_id, hid_t dxpl_id, const hsize_t offset, uint32_t filters,
| ^~~~~~~~~~~~~~
/usr/local/include/h5pp/details/h5ppHdf5.h:2061:43: error: too few arguments to function ‘herr_t H5Dread_chunk2(hid_t, hid_t, const hsize_t, uint32_t, void*, size_t*)’ [-Wtemplate-body]
2061 | herr_t err = H5Dread_chunk(h5dset, h5dxpl, chunkOffset.data(), &mask, chunkBuffer.data());
| ^
/usr/include/H5Dpublic.h:1303:15: note: declared here
1303 | H5_DLL herr_t H5Dread_chunk2(hid_t dset_id, hid_t dxpl_id, const hsize_t *offset, uint32_t *filters,
| ^~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/h5pp-test-appendToDataset.dir/build.make:79: CMakeFiles/h5pp-test-appendToDataset.dir/test-appendToDataset.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:240: CMakeFiles/h5pp-test-appendToDataset.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

[DavidAce]

HDF5 2.0 is a rather large version upgrade, with many breaking changes.
I intend to support HDF5 2.0 and above with h5pp, but transitioning 1.x to 2.x will take some time (a few months, perhaps). It's probably best to take the opportunity to introduce h5pp 2.0 as well, to address some annoyances with the api. In the meantime, my advice is to link h5pp to HDF5 versions 1.x, e.g. by letting h5pp build HDF5 from source, or by installing h5pp through conan https://conan.io/center/recipes/h5pp