Skip to content

Commit 5887c9e

Browse files
authored
Merge pull request Unidata#3076 from WardF/tiny-cleanup.wif
Clean up a couple small things while I'm looking at them.
2 parents 85c8bc8 + 2ef02c0 commit 5887c9e

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

.github/workflows/run_tests_win_cygwin.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ jobs:
9191
- name: Upload autoconf test results
9292
uses: actions/upload-artifact@v4
9393
with:
94-
name: cygwin-autotools-test-logs
94+
name: cygwin-autotools-test-logs-${{ github.run_id }}
9595
path: |
96-
*/*.log
97-
*/*.trs
96+
*/*.log
97+
*/*.trs
9898

9999
build-and-test-cmake:
100100
name: Cygwin-based CMake tests

CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1649,10 +1649,6 @@ install(FILES ${netCDF_BINARY_DIR}/netcdf.pc
16491649
##
16501650
print_conf_summary()
16511651

1652-
# Enable Makedist files.
1653-
ADD_MAKEDIST()
1654-
ENABLE_MAKEDIST(README.md COPYRIGHT RELEASE_NOTES.md INSTALL INSTALL.cmake test_prog.c lib_flags.am cmake CMakeLists.txt COMPILE.cmake.txt config.h.cmake.in cmake_uninstall.cmake.in netcdf-config-version.cmake.in netcdf-config.cmake.in FixBundle.cmake.in nc-config.cmake.in configure configure.ac install-sh config.h.in config.sub CTestConfig.cmake.in)
1655-
16561652
#####
16571653
# Configure and print the libnetcdf.settings file.
16581654
#####

libdap4/d4meta.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ decodeEconst(NCD4meta* builder, NCD4node* enumtype, const char* nameorval, union
893893
{
894894
size_t i;
895895
int ret = NC_NOERR;
896-
union ATOMICS number;
896+
union ATOMICS number = {0};
897897
NCD4node* match = NULL;
898898

899899
/* First, see if the value is an econst name */
@@ -902,7 +902,7 @@ decodeEconst(NCD4meta* builder, NCD4node* enumtype, const char* nameorval, union
902902
if(strcmp(ec->name,nameorval)==0) {match = ec; break;}
903903
}
904904
/* If no match, try to invert as a number to see if there is a matching econst */
905-
if(!match) {
905+
if(!match && enumtype->en.econsts) {
906906
/* get the incoming value as number */
907907
if((ret=convertString(&number,enumtype->basetype,nameorval)))
908908
goto done;

0 commit comments

Comments
 (0)