[v2.2] Updated sink recognition due to the replacement of PulseAudio with Pipewire in KDE + more detailed interface

Author: DevEmperor

README.md

@@ -11,7 +11,7 @@
 ## Dependencies
 
 - Python 3.6 or higher
-- any Linux distribution with PulseAudio as its sound server
+- any Linux distribution with Pipewire & PulseAudio as its sound server
 - git, ffmpeg and pip
 
 
@@ -40,7 +40,7 @@
 
 ## Usage
 
-1. Run LSD with "`python3 lsd.py`"
+1. Run LSD with `python3 lsd.py`
 2. Enter the path to your output directory. (If you always want to export to the same folder, you can also enter the path in the configuration section of "*lsd.py*")
 3. Open the Spotify Application and wait a few seconds until LSD has initialized the recording interface using PulseAudio
 4. Now you can play a playlist, audiobook, podcast or individual tracks. Everything is recorded and then separated and tagged fully automatically.
@@ -51,4 +51,4 @@
 
 ## License
 
-Fastr is under the terms of the [Apapche 2.0 license](https://www.apache.org/licenses/LICENSE-2.0), following all clarifications stated in the [license file](https://raw.githubusercontent.com/DevEmperor/LSD/master/LICENSE)
+LSD is under the terms of the [Apapche 2.0 license](https://www.apache.org/licenses/LICENSE-2.0), following all clarifications stated in the [license file](https://raw.githubusercontent.com/DevEmperor/LSD/master/LICENSE)

lsd.py

@@ -31,8 +31,8 @@
 # main-function
 if __name__ == '__main__':
     # verify that the Pulseaudio and the parec-command is installed on this system
-    if subprocess.Popen("parec --help && pacmd --help", stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, shell=True).wait() != 0:
-        exit("{} This script needs a Linux system with Pulseaudio installed (e.g. KDE) to record tracks.".format(ERROR))
+    if subprocess.Popen("parec --help && pw-cli --help", stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, shell=True).wait() != 0:
+        exit("{} This script needs a Linux system with Pipewire & Pulseaudio installed (e.g. KDE) to record tracks.".format(ERROR))
 
     # always check for ctrl+c
     try:
@@ -47,15 +47,16 @@
               gap + f"██{RED}║{RST}      {YELLOW}╚════{RST}██{YELLOW}║{RST} ██{GREEN}║{RST}  ██{GREEN}║{RST}" +
               gap + f"███████{RED}╗{RST} ███████{YELLOW}║{RST} ██████{GREEN}╔╝{RST}" +
               gap + f"{RED}╚══════╝{RST} {YELLOW}╚══════╝{RST} {GREEN}╚═════╝{RST}" +
-              "\n" + " " * (T_WIDTH // 2 - 14) + " Linux-Spotify-Downloader 2.1" +
+              "\n" + " " * (T_WIDTH // 2 - 14) + " Linux-Spotify-Downloader 2.2" +
               gap + " developed by Jannis Zahn")
 
         # specify the output-directory
         print("\n" + "---- CONFIGURATION " + "-" * (T_WIDTH - 19) + "\n")
         if not os.path.isdir(OUTPUT_DIR):
             while True:
                 OUTPUT_DIR = input("{} Please specify an existing and writable output-directory: ".format(REQUEST))
-                if os.path.isdir(OUTPUT_DIR): break
+                if os.path.isdir(OUTPUT_DIR):
+                    break
         OUTPUT_DIR = os.path.abspath(OUTPUT_DIR)
         print("{} Output-Directory: {}".format(INFO, OUTPUT_DIR))
 
@@ -74,39 +75,40 @@
         print("\r{} OK, I have found a running Spotify-Application".format(INFO))
 
         # find spotify-input-sink and create monitor to record from
-        print("{} I have to play a track to create a new recording interface ...".format(INFO), end="", flush=True)
+        print("{} I have to play a track to create a new recording interface ...".format(INFO))
         methods_if.Play()
-        time.sleep(3)
+        time.sleep(1)
         while True:
-            sink_inputs = subprocess.run(["pacmd", "list-sink-inputs"], stdout=subprocess.PIPE).stdout.decode()
-            if "application.name = \"Spotify\"" in sink_inputs: break
+            sink_inputs = subprocess.run("pw-cli ls Node".split(), stdout=subprocess.PIPE).stdout.decode()
+            if "application.name = \"spotify\"" in sink_inputs:
+                break
             time.sleep(1)
         methods_if.Pause()
         time.sleep(0.5)
-        sink_index = sink_inputs.split("application.name = \"Spotify\"")[0].split("index: ")[-1].split("\n")[0]
-        if subprocess.Popen(f"pactl load-module module-null-sink sink_name=lsd && pactl move-sink-input {sink_index} "
-                            f"lsd", stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, shell=True).wait() == 0:
-            print("\r{} I have successfully created the recording interface to record from Spotify only.\n".format(INFO)
-                  + "{}    I will now listen for tracks to be played ... Please close Spotify as soon as you finished "
-                    "playing all songs!{}".format(BOLD, RST))
+        sink_index = sink_inputs.split("application.name = \"spotify\"")[0].split("\tid ")[-1].split(",")[0]
+        if subprocess.Popen("pactl load-module module-null-sink sink_name=lsd && pactl move-sink-input {} lsd".format(sink_index),
+                            stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, shell=True).wait() == 0:
+            print("{}{} I will now listen for tracks to be played ..."
+                  "Please close Spotify as soon as you finished playing all songs!{}".format(INFO, BOLD, RST))
         else:
             exit("\r{} Error while creating the recording device for Spotify.".format(ERROR))
 
         # start the recording with parec (PulseAudio-Recording)
         print("\n" + "---- RECORDING " + "-" * (T_WIDTH - 15) + "\n")
-        recording_process = subprocess.Popen(f"parec -d lsd.monitor --file-format=wav".split() + [OUTPUT_DIR + "/.temp.wav"])
+        recording_process = subprocess.Popen("parec -d lsd.monitor --file-format=wav".split() + [OUTPUT_DIR + "/.temp.wav"])
 
         # initialize some variables
         last_url = ""
         counter = 0
         tracks = []
         ad = False
 
-        # wait until first song starts (to make it possible to record also the current song)
-        while prop_if.Get("org.mpris.MediaPlayer2.Player", "PlaybackStatus") != "Playing": time.sleep(0.01)
-
         # continue reading dbus-properties until Spotify gets closed
         try:
+            # wait until first song starts (to make it possible to record also the current song)
+            while prop_if.Get("org.mpris.MediaPlayer2.Player", "PlaybackStatus") != "Playing":
+                time.sleep(0.01)
+
             while True:
                 # get all meta-information about the current track
                 meta = prop_if.Get("org.mpris.MediaPlayer2.Player", "Metadata")
@@ -125,7 +127,7 @@
 
         except dbus.exceptions.DBusException:  # means that Spotify is closed, because there is no bus any more
             recording_process.terminate()  # stop the recording
-            subprocess.Popen(["pulseaudio", "-k"])  # restore original pulseaudio-configuration
+            subprocess.Popen("systemctl --user restart pipewire pipewire-pulse".split())  # restore original pulseaudio-configuration
             print("{} I have recorded {} track(s).".format(INFO, counter))
 
             if counter > 0:
@@ -149,9 +151,9 @@
                 for idx, audio in enumerate(chunks):
                     if audio.duration_seconds >= 40:
                         song = sp.track(tracks[idx - skipped])
-                        print("\r{} Converting and tagging \"{}\" ...".format(INFO, song["name"]) + " " * (T_WIDTH - 33 - len(song["name"])), end="", flush=True)
+                        print("{} Converting and tagging \"{}\" ...".format(INFO, song["name"]))
 
-                        if genius.access_token == "Bearer asd":
+                        if genius.access_token.startswith("Bearer"):
                             genius_song = genius.search_song(song["name"], song["artists"][0]["name"])
                             if genius_song is not None:
                                 lyrics = genius_song.lyrics
@@ -177,12 +179,13 @@
 
                         audio.export(OUTPUT_DIR + "/" + song["name"].replace("-", "~").replace("/", "~")
                                      .replace("|", "~") + ".mp3", format="mp3", bitrate="192k", tags=tags, cover=OUTPUT_DIR + "/.cover.jpg")
-                    else: skipped += 1
+                    else:
+                        skipped += 1
                 os.remove(OUTPUT_DIR + "/.temp.mp3")  # remove all temporary files
                 os.remove(OUTPUT_DIR + "/.cover.jpg")
             os.remove(OUTPUT_DIR + "/.temp.wav")
-            print("\r{}{} Done!".format(INFO, GREEN) + " " * (T_WIDTH - 9))
+            print("{}{} Done!".format(INFO, GREEN))
 
     except KeyboardInterrupt:
-        subprocess.Popen(["pulseaudio", "-k"])
+        subprocess.Popen("systemctl --user restart pipewire pipewire-pulse".split())
         exit("\n{}Detected Ctrl+C (Keyboard-Interrupt) ... Bye! :-)".format(RED))