-
Notifications
You must be signed in to change notification settings - Fork 170
Open
Labels
A-coreArea: Core tierArea: Core tierfuzzingCrashs and other bugs found by fuzzingCrashs and other bugs found by fuzzinggood first issueGood for newcomersGood for newcomers
Description
The arbitrary feature is currently broken / not consistently compiled. We want it working again and wired correctly across crates that define PDUs.
Scope
- Add/repair
arbitraryfeature flags in crates that own PDU structs/enums - Ensure the dependency is optional and feature-gated
- Ensure it works in both
stdandno_std + alloccontexts where applicable - Document “how to build with arbitrary” in the relevant .md documents
Tasks
- Identify target crates (likely
ironrdp-pduand any other protocol crates that expose PDU types) - Add
arbitrary = { version = "1", features = ["derive"], optional = true } - Add features wiring (
arbitrary = ["dep:arbitrary", ...]) - Check
cargo check -p <crate> --features arbitrarypasses locally
[dependencies]
arbitrary = { version = "1", features = ["derive"], optional = true }
[features]
# Pick one:
# - If the crate is std-only: arbitrary = ["std", "dep:arbitrary"]
# - If the crate supports no_std + alloc: arbitrary = ["alloc", "dep:arbitrary"]
arbitrary = ["alloc", "dep:arbitrary"]Acceptance criteria
cargo checkfor the target crates succeeds with--features arbitrary- No breaking change for default feature sets
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-coreArea: Core tierArea: Core tierfuzzingCrashs and other bugs found by fuzzingCrashs and other bugs found by fuzzinggood first issueGood for newcomersGood for newcomers