Merge pull request #34 from DoWithLogic/32-observabilityinittracerprovider-breaks-interface-segregation-principle

fix #32

Author: martinyonatann

cmd/api/main.go

@@ -29,13 +29,13 @@ func main() {
 	// Initialize observability components if observability is enabled in the configuration.
 	if cfg.Observability.Enable {
 		// Initialize the tracer provider for distributed tracing.
-		tracer, err := observability.InitTracerProvider(cfg)
+		tracer, err := observability.InitTracerProvider(cfg.Observability, cfg.App)
 		if err != nil {
 			log.Warn("Failed to initialize tracer: ", err)
 		}
 
 		// Initialize the meter provider for metrics collection.
-		meter, err := observability.InitMeterProvider(cfg)
+		meter, err := observability.InitMeterProvider(cfg.Observability, cfg.App)
 		if err != nil {
 			log.Warn("Failed to initialize meter: ", err)
 		}

pkg/observability/metrics.go

@@ -28,14 +28,14 @@ const (
 // Returns:
 // - A pointer to an OpenTelemetry MeterProvider.
 // - An error if any occurs during initialization or setting up the provider.
-func InitMeterProvider(config config.Config) (*sdkmetric.MeterProvider, error) {
+func InitMeterProvider(observability config.ObservabilityConfig, app config.AppConfig) (*sdkmetric.MeterProvider, error) {
 	var (
 		exporter sdkmetric.Exporter
 		err      error
 	)
 
 	// Determine the type of metric exporter based on the observability mode.
-	switch config.Observability.Mode {
+	switch observability.Mode {
 	case OTLP_HTTP_MODE:
 		exporter, err = otlpmetrichttp.New(
 			context.Background(),
@@ -57,7 +57,7 @@ func InitMeterProvider(config config.Config) (*sdkmetric.MeterProvider, error) {
 	// Create and configure the MeterProvider with a periodic reader for exporting metrics.
 	mp := sdkmetric.NewMeterProvider(
 		sdkmetric.WithReader(sdkmetric.NewPeriodicReader(exporter, sdkmetric.WithInterval(2*time.Second))),
-		sdkmetric.WithResource(initResource(config.App.Name, config.App.Version, config.App.Environment)),
+		sdkmetric.WithResource(initResource(app.Name, app.Version, app.Environment)),
 	)
 
 	// Set the MeterProvider as the global meter provider.

pkg/observability/tracer.go

@@ -15,14 +15,14 @@ import (
 // initializeTracerProvider initializes and configures a tracer provider based on the observability mode from the configuration.
 // It supports OTLP gRPC, OTLP HTTP, and stdout (default) exporters for trace data.
 // Returns a tracer provider instance or an error if initialization fails.
-func InitTracerProvider(config config.Config) (*sdktrace.TracerProvider, error) {
+func InitTracerProvider(observabilityCfg config.ObservabilityConfig, appCfg config.AppConfig) (*sdktrace.TracerProvider, error) {
 	var (
 		exporter sdktrace.SpanExporter
 		err      error
 	)
 
 	// Determine the exporter type based on the observability mode.
-	switch config.Observability.Mode {
+	switch observabilityCfg.Mode {
 	case OTLP_GRPC_MODE:
 		exporter, err = otlptracegrpc.New(
 			context.Background(),
@@ -45,7 +45,7 @@ func InitTracerProvider(config config.Config) (*sdktrace.TracerProvider, error)
 	tracerProvider := sdktrace.NewTracerProvider(
 		sdktrace.WithSampler(sdktrace.AlwaysSample()),
 		sdktrace.WithBatcher(exporter),
-		sdktrace.WithResource(initResource(config.App.Name, config.App.Version, config.App.Environment)),
+		sdktrace.WithResource(initResource(appCfg.Name, appCfg.Version, appCfg.Environment)),
 	)
 
 	// Set the global tracer provider for the OpenTelemetry API.