channel: Add test for channel state max

Adds a test so CI will fail if CHANNEL_STATE_MAX isn’t updated when new channel states are added.

Changelog-None

Author: ddustin

common/test/run-channel_type.c

@@ -4,6 +4,7 @@
 #include <ccan/tal/str/str.h>
 #include <common/setup.h>
 #include <stdio.h>
+#include <lightningd/channel_state.h>
 
 /* AUTOGENERATED MOCKS START */
 /* Generated stub for amount_asset_is_main */
@@ -114,6 +115,42 @@ static void assert_names_eq(const char **names, const char *expected)
 		assert(streq(expected_names[i], names[i]));
 }
 
+static enum channel_state calc_channel_state_max(void)
+{
+	enum channel_state largest_state = 0;
+
+	assert(DUALOPEND_OPEN_INIT == 1);
+	for (enum channel_state state = 1;; state++) {
+		bool known_state;
+		switch(state) {
+			case DUALOPEND_OPEN_INIT:
+			case CHANNELD_AWAITING_LOCKIN:
+			case CHANNELD_NORMAL:
+			case CHANNELD_SHUTTING_DOWN:
+			case CLOSINGD_SIGEXCHANGE:
+			case CLOSINGD_COMPLETE:
+			case AWAITING_UNILATERAL:
+			case FUNDING_SPEND_SEEN:
+			case ONCHAIN:
+			case CLOSED:
+			case DUALOPEND_OPEN_COMMITTED:
+			case DUALOPEND_AWAITING_LOCKIN:
+			case CHANNELD_AWAITING_SPLICE:
+			case DUALOPEND_OPEN_COMMIT_READY:
+				largest_state = state;
+				known_state = true;
+				break;
+			default:
+				known_state = false;
+				break;
+		}
+		if (!known_state)
+			break;
+	}
+
+	return largest_state;
+}
+
 int main(int argc, char *argv[])
 {
 	struct channel_type t;
@@ -125,6 +162,8 @@ int main(int argc, char *argv[])
 	assert_names_eq(channel_type_name(tmpctx, channel_type_anchors_zero_fee_htlc(tmpctx)),
 			"static_remotekey/even anchors/even");
 
+	assert(calc_channel_state_max() == CHANNEL_STATE_MAX);
+
 	t.features = tal_arr(tmpctx, u8, 0);
 	set_feature_bit(&t.features, 1000);
 	assert_names_eq(channel_type_name(tmpctx, &t), "unknown_1000/even");