Skip to content

Commit 53cb2ce

Browse files
author
Claudio Raimondi
committed
Add better stripping [skip ci]
1 parent 863cdeb commit 53cb2ce

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,10 @@ EOF
161161
RUN ./configure --prefix=/tmp/lightning_install --enable-static --disable-compat --disable-valgrind
162162
COPY .git/ .git/
163163
RUN git submodule update --init --recursive --jobs $(nproc) --depth 1
164+
#TODO: do not install manpages
164165
RUN uv run make -j$(nproc) install
165166

166-
RUN for f in /tmp/lightning_install/bin/*; do \
167+
RUN for f in /tmp/lightning_install/bin/* /tmp/lightning_install/libexec/c-lightning/* /tmp/lightning_install/libexec/c-lightning/plugins/*; do \
167168
if file "$f" | grep -q 'ELF'; then \
168169
${STRIP} --strip-unneeded "$f"; \
169170
fi; \
@@ -182,6 +183,7 @@ RUN apt-get update && \
182183

183184
COPY --from=downloader /opt/bitcoin/bin/bitcoin-cli /usr/bin/
184185
COPY --from=downloader /opt/litecoin/bin/litecoin-cli /usr/bin/
186+
#TODO: don't copy manpages (/tmp/lightning_install/share)
185187
COPY --from=builder /tmp/lightning_install/ /usr/local/
186188

187189
COPY tools/docker-entrypoint.sh /entrypoint.sh

doc/getting-started/getting-started/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ docker pull elementsproject/lightningd:v24.05
4444
To run the Docker container:
4545

4646
```shell
47-
docker run --rm --init --user $(id -u):$(id -g) -v /path/on/host/lightning-data:/root/.lightning -p 9735:9735 -p 9835:9835 lightningd
47+
docker run --rm --init -v /path/on/host/lightning-data:/root/.lightning -p 9735:9735 -p 9835:9835 lightningd
4848
```
4949

5050
See all of the docker images for Core Lightning on [Docker Hub](https://hub.docker.com/r/elementsproject/lightningd/tags).

0 commit comments

Comments
 (0)