Skip to content

Commit cc7da09

Browse files
authored
Remove TODOs [skip ci]
1 parent 66a9497 commit cc7da09

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

Dockerfile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ WORKDIR /opt
147147
RUN ./install-uv.sh -q
148148
RUN ./install-rust.sh -y --target ${target_arch_rust} --profile minimal
149149

150-
#TODO: error here when building for `arm`
151150
ENV PATH="/root/.cargo/bin:/root/.local/bin:${PATH}"
152151

153152
WORKDIR /opt/lightningd
@@ -158,13 +157,12 @@ linker = "${target_arch}-gcc"
158157
rustflags = ["-C", "target-cpu=generic"]
159158
EOF
160159

161-
#TODO: maybe only compile lightningd? instead of all the plugins as well
162-
RUN ./configure --prefix=/opt/lightningd --enable-static --disable-compat --disable-valgrind
160+
RUN ./configure --prefix=/tmp/lightning_install --enable-static --disable-compat --disable-valgrind
163161
COPY .git/ .git/
164162
RUN git submodule update --init --recursive --jobs $(nproc) --depth 1
165163
RUN uv run make -j$(nproc) install
166164

167-
RUN ${STRIP} --strip-unneeded bin/lightningd
165+
RUN ${STRIP} --strip-unneeded #TODO: fix
168166

169167
FROM base-target AS final
170168

@@ -179,7 +177,7 @@ RUN apt-get update && \
179177

180178
COPY --from=downloader /opt/bitcoin/bin/bitcoin-cli /usr/bin/
181179
COPY --from=downloader /opt/litecoin/bin/litecoin-cli /usr/bin/
182-
COPY --from=builder /opt/lightningd/bin/lightningd /usr/local/bin/
180+
COPY --from=builder /tmp/lightning_install /usr/local/
183181

184182
COPY tools/docker-entrypoint.sh /entrypoint.sh
185183

0 commit comments

Comments
 (0)