Replies: 1 comment
-
|
@dalonsoa Some very rough notes about the output files. Happy deleting! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
WORK IN PROGRESS
Doing an audit of the outputs defined in
outputs/mca.pyto figure out what everything is doing and decide what we need to keep and what we can get rid of.NOTES:
My initial feeling is that we can probably get rid of
metric_supply,metricy_supply,metric_consumption,metricy_consumption,AggregateResourcesandFiniteResources.The costs outputs can also be tidied and homogenised. Some functions are recalculating supply and consumption, some are taking them directly from
market- presumably all of them could be doing the latter. Also a lot of the maths is repeated multiple times throughout the codebase. For example we have three functions for calculating LCOE. Why not one function that is called in three places?The code in this module is the opposite of DRY (wet?). For example,
capacity_to_service_demand()is defined (identically) in bothsector_lcoeandsector_eac. This really needs to be improvedThe
metricy_supply,metricy_consumptionand all the costs outputs fail with the same error:ValueError: cannot insert hour, already existsThe format of the costs files is very heterogeneous. we should standardise this - what columns do we need in these files and what can we leave out?
What is "dst_region"?
Lots of files have a "units_prices" column which isn't necessary
SUPPLY
supplymarketmetric_supply(registered as "timeslice_supply")sector_supplyfunctionmuse.production.supplyfunction, which calls themuse.quantities.supplyfunction - this is the function used for the adhoc solver which doesn't include the minimum service constraintmetricy_supply(registered as "yearly_supply")sectory_supplyfunctionmetric_supply-> can definitely delete thisCONSUMPTION
consumptionmarketmetric_consumption(registered as "timeslice_consumption")sector_consumptionfunctionmuse.production.supply, as above) and consumption (usingmuse.quantities.consumption)metricy_consumption(registered as "yearly_consumption")metricy_supplyPRICES
pricesmarketCAPACITY
capacitysectorslistsector_capacityfunction. Look like this isn't recalculating anything but just summing data across assets, although I'm confused as I recall the capacity files having multiple rows for different assets. Look into this.COSTS
metric_fuel_costs(registered as "fuel_costs")sector_fuel_costsfunctionmetric_capital_costs(registered as "capital_costs")sector_capital_costsfunctionsectors, and then recalculates capital costs based on capacity. Also gets consumption data directly frommarket, but this isn't used in the calculations.metric_emission_costs(registered as "emission_costs")sector_emission_costsfunctionmetric_lcoe(registered as "LCOE")sector_lcoefunctionmetric_eac(registered as "EAC")sector_eacfunctionOTHER
AggregateResourcesFiniteResources(registered as "finite_resources")Beta Was this translation helpful? Give feedback.
All reactions